feat: extract JsonDecoder interface to decouple graphql from Jackson#3240
Merged
feat: extract JsonDecoder interface to decouple graphql from Jackson#3240
Conversation
Signed-off-by: Marvin Froeder <[email protected]>
703ab3f to
1d307ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feign.codec.JsonDecoderinterface infeign-corethat extendsDecoderwith an additionaldecode(Object, Type)method for in-memory object conversionGraphqlDecoderto accept a singleJsonDecoderinstead of directly depending onObjectMapper, removing thejackson-databindcompile dependency from the graphql moduleJsonDecoder.decode(Object, Type)method enables direct Map-to-target-type conversion, avoiding the previous serialize-then-deserialize round-tripAll new types are annotated with
@Experimental.Test plan
JacksonJsonDecoder🤖 Generated with Claude Code