Extract inner Default classes to standalone top-level classes#3237
Merged
Extract inner Default classes to standalone top-level classes#3237
Conversation
Signed-off-by: Marvin Froeder <[email protected]>
velo
force-pushed
the
extract-default-inner-classes
branch
from
bc29ea7 to
54873f0
Compare
|
What was the motivation for this PR? |
Member
Author
|
did it broke something? |
Member
Author
|
|
You deprecated 9 classes with no explanation of what the benefit was. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Defaultimplementation classes from their parent interfaces into standalone top-level classes (DefaultClient,DefaultAsyncClient,DefaultContract,DefaultRetryer,DefaultEncoder,DefaultDecoder,DefaultErrorDecoder,DefaultInvocationHandlerFactory,DefaultQueryMapEncoder)Defaultclasses, reducing them to thin subclasses that delegate to the new standalone classesTest plan
mvn testpasses across all modulesClient.Proxiedcorrectly extendsDefaultClientinstead of the deprecatedClient.Default🤖 Generated with Claude Code