Skip to content

feign.Logger doesn't close response.body() #2529

@nazukin-dmitrii-sravni

Description

@nazukin-dmitrii-sravni

When feign.Logger copies Response in method logAndRebufferResponse, it makes new instance of Response.Body, but it doesn't close original Response.Body.
It only closes underlying InputStream in the next line.

byte[] bodyData = Util.toByteArray(response.body().asInputStream());

Looks like, it could be potential leak of resources/connections. What do you think?

For example Response.Body implementation for apache hc5 is never executed.

      @Override
      public void close() throws IOException {
        try {
          EntityUtils.consume(entity);
        } finally {
          httpResponse.close();
        }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions