[UI] Use Angular property binding for SVG fill attribute#3542
Merged
sfeilmeier merged 2 commits intodevelopfrom Jan 24, 2026
Merged
[UI] Use Angular property binding for SVG fill attribute#3542sfeilmeier merged 2 commits intodevelopfrom
sfeilmeier merged 2 commits intodevelopfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3542 +/- ##
=============================================
- Coverage 59.36% 59.35% -0.01%
Complexity 105 105
=============================================
Files 3066 3066
Lines 132833 132833
Branches 9816 9816
=============================================
- Hits 78841 78826 -15
- Misses 51011 51019 +8
- Partials 2981 2988 +7 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces attr.fill="{{ fillRef }}" with [attr.fill]="fillRef" in SVG polygon bindings for improved Angular consistency and maintainability. The property binding syntax [attr.fill] is the standard Angular approach for dynamic attribute values, ensuring type safety, better template parsing, and alignment with the rest of the codebase.
Based on #3377