Kostal Piko inverter: Corrected dayYield from kWh to Wh + Units of totalYield and dayYield#3538
Merged
sfeilmeier merged 5 commits intoOpenEMS:developfrom Jan 23, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #3538 +/- ##
=============================================
+ Coverage 59.17% 59.22% +0.05%
Complexity 105 105
=============================================
Files 3040 3040
Lines 132213 132217 +4
Branches 9757 9756 -1
=============================================
+ Hits 78225 78287 +62
+ Misses 51047 50978 -69
- Partials 2941 2952 +11 🚀 New features to boost your workflow:
|
sfeilmeier
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also updated test case to handle a floating point number.
This is a cleaned up version of PR #3499
@sfeilmeier please review & merge again.
@Sn0w3y you might want to have a look as well, as you did most of the work of the component.