Fix: Pull-to-Refresh not working#3531
Merged
sfeilmeier merged 4 commits intoOpenEMS:developfrom Jan 23, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3531 +/- ##
=============================================
+ Coverage 59.17% 59.18% +0.01%
Complexity 105 105
=============================================
Files 3040 3040
Lines 132213 132213
Branches 9757 9757
=============================================
+ Hits 78225 78237 +12
+ Misses 51047 51036 -11
+ Partials 2941 2940 -1 🚀 New features to boost your workflow:
|
lukasrgr
approved these changes
Jan 21, 2026
sfeilmeier
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull-to-refresh doesn't work properly on the Live page. Two issues:
ion-refresheris placed outsideion-content- Ionic requires it to be insidelive.component.htmlthat shouldn't be thereChanges
pull-to-refresh.tsMoved the refresher inside
ion-contentwhere it belongs. Also changed the logic so the pull gesture is always available - the visual hint ("Pull to refresh" text with arrows) still only shows when data is stale.Before:
@if (show) { <ion-refresher>...</ion-refresher> } <ion-content>...</ion-content>After:
live.component.htmlRemoved the duplicate
ion-refresherthat was passed as content - the component already handles this via the[refresh]input.Also moved all the grid content inside
oe-refresh-viewso it's actually scrollable with the refresher.How to test