Fix Single threshold UI unit labels#3515
Merged
sfeilmeier merged 3 commits intoOpenEMS:developfrom Feb 6, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3515 +/- ##
=============================================
+ Coverage 59.61% 59.62% +0.01%
Complexity 105 105
=============================================
Files 3004 3006 +2
Lines 130410 130472 +62
Branches 9637 9639 +2
=============================================
+ Hits 77737 77778 +41
- Misses 49764 49783 +19
- Partials 2909 2911 +2 🚀 New features to boost your workflow:
|
Contributor
Author
|
Before: Now: 
|
Contributor
|
@lukasrgr anything you need from our side to be able to review? |
lukasrgr
approved these changes
Jan 26, 2026
Contributor
lukasrgr
left a comment
lukasrgr
left a comment
There was a problem hiding this comment.
thx for your contribution 🚀
Contributor
|
Ich denke @sfeilmeier ready to launch (the merge process) ;) |
sfeilmeier
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the modal window of the ChannelSingleThreshold controller some units are hard coded to "W", but it's possible to use input channels with other units.
Now the labels are built with dynamic expressions that are using the input channel unit.
Since the SI-Unit for temperature is °C and not C the corresponding changes have been made in io.openems.common/src/io/openems/common/channel/Unit.java.