pvinverter: Kostal Piko Corrected dayYield from kWh to Wh and corrected Units of totalYield a…#3499
Closed
sjjh wants to merge 22 commits intoOpenEMS:developfrom
Closed
pvinverter: Kostal Piko Corrected dayYield from kWh to Wh and corrected Units of totalYield a…#3499sjjh wants to merge 22 commits intoOpenEMS:developfrom
sjjh wants to merge 22 commits intoOpenEMS:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #3499 +/- ##
==============================================
- Coverage 59.21% 29.16% -30.05%
==============================================
Files 3040 289 -2751
Lines 132207 8233 -123974
Branches 9758 1409 -8349
==============================================
- Hits 78269 2400 -75869
+ Misses 50979 5706 -45273
+ Partials 2959 127 -2832 🚀 New features to boost your workflow:
|
Contributor
Author
|
Currently the daily sum in OpenEMS UI is cut off as int. For example, a daily yield of 0.16 kWh is displayed as 0 kWh. I recognized in the code base, that |
sjjh
changed the title
sjjh
changed the title
sfeilmeier
requested changes
Jan 19, 2026
Contributor
sfeilmeier
left a comment
sfeilmeier
left a comment
There was a problem hiding this comment.
Looks ok in principle - but JUnit test fails:
PvInverterKostalPikoImplTest > test FAILED
java.lang.Exception at PvInverterKostalPikoImplTest.java:126
Contributor
Author
|
Thx for the hint. Corrected it. But messed up my local git, thus need some time to push the commits. Will notify once it is ready. |
Applyingg existing implementation from https://github.com/fanass-dev/openems/tree/feature/MeterFronius/io.openems.edge.meter.fronius to current OpenEMS develop. Cf https://community.openems.io/t/fronius-symo-liefert-keine-daten/2356/10
Refactored modbus values from ScaledValuePoint to ValuePoint
- Move SunSpec-Mappings for S213 to AbstractSunSpecMeter - Add "invert" to comply with inverted energy mappings TODO: - [ ] Complete Modbus JUnit-Test; including "invert" - [ ] Fix activate() for all Modbus Meter implementations - [ ] Continue Review - [ ] Merge alle Fronius bundles to one (in separate PR)
* Bump org.jmdns:jmdns from 3.6.2 to 3.6.3 in /cnf Bumps [org.jmdns:jmdns](https://github.com/jmdns/jmdns) from 3.6.2 to 3.6.3. - [Release notes](https://github.com/jmdns/jmdns/releases) - [Changelog](https://github.com/jmdns/jmdns/blob/main/CHANGELOG.txt) - [Commits](jmdns/jmdns@3.6.2...v3.6.3) --- updated-dependencies: - dependency-name: org.jmdns:jmdns dependency-version: 3.6.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * Update bndrun --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Stefan Feilmeier <[email protected]>
* Bump org.jsoup:jsoup from 1.21.2 to 1.22.1 in /cnf Bumps [org.jsoup:jsoup](https://github.com/jhy/jsoup) from 1.21.2 to 1.22.1. - [Release notes](https://github.com/jhy/jsoup/releases) - [Changelog](https://github.com/jhy/jsoup/blob/master/CHANGES.md) - [Commits](jhy/jsoup@jsoup-1.21.2...jsoup-1.22.1) --- updated-dependencies: - dependency-name: org.jsoup:jsoup dependency-version: 1.22.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * Update bndrun --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Stefan Feilmeier <[email protected]>
…ess image (#3490) - added newline to fix unordered list in section "6. Process Image". - typographically corrected the dashes in the last sentence of the section.
…rvices (#3489) - Corrected title from "Controller" to "Device and Service". - In introduction section added "services" in addition to "devices" as description.
… IO) (#3488) * extends docu on Dynamic Documentation Generation, Natures in general and 2 specific natures: ESS & IO * improved ALT-texts of images to improve accessability
Contributor
Author
|
I tried to sort it out and hope to not have messed up the complete git history. The build is still failing, but this should not be related to my commits? |
Contributor
Author
|
As I messed up the commit history here, I'll close this and opened the new PR #3538. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nd dayYield