Add Single Channel datasource for dynamic simulation input#3448
Merged
sfeilmeier merged 2 commits intoOpenEMS:developfrom Dec 11, 2025
Merged
Add Single Channel datasource for dynamic simulation input#3448sfeilmeier merged 2 commits intoOpenEMS:developfrom
sfeilmeier merged 2 commits intoOpenEMS:developfrom
Conversation
Introduces SimulatorDatasourceSingleChannel, allowing external setting of simulation values via a writable channel. Updates documentation to describe available datasource types and usage. Refactors AbstractCsvDatasource to AbstractDatasource and updates references. Removes unused timeDelta from SingleDirect datasource configuration and tests.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #3448 +/- ##
=============================================
+ Coverage 59.62% 59.64% +0.02%
Complexity 112 112
=============================================
Files 2894 2896 +2
Lines 124658 124694 +36
Branches 9343 9345 +2
=============================================
+ Hits 74318 74356 +38
+ Misses 47522 47516 -6
- Partials 2818 2822 +4 🚀 New features to boost your workflow:
|
Added comprehensive unit tests for getValues, getKeys, getTimeDelta, null value handling, and channel accessors in SimulatorDatasourceSingleChannelImplTest. Improved type safety in getValues implementation by explicitly casting the value to the generic type.
Contributor
|
You used #3313 as base for this, didn't you? I'll close my merge request in favor of yours :) |
Collaborator
Author
I already wrote it in the Description! :) I did ! :) Thanks again ! |
Contributor
|
I'm blind, seeing it now that it's in the description. thanks :D |
Contributor
|
I love the documentation you've added 🤩 |
Collaborator
Author
Thanks! As many "noob" Users keep complaining i thought it would be good.. |
da-Kai
approved these changes
Nov 27, 2025
Collaborator
Author
|
@sfeilmeier i guess this is ready to merge :) |
sfeilmeier
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces SimulatorDatasourceSingleChannel, allowing external setting of simulation values via a writable channel. Updates documentation to describe available datasource types and usage. Refactors AbstractCsvDatasource to AbstractDatasource and updates references. Removes unused timeDelta from SingleDirect datasource configuration and tests.
Based on #3313
Co-Authored-By: @parapluplu