Kostal Plenticore: correct and simplify smartmode#3417
Kostal Plenticore: correct and simplify smartmode#3417sfeilmeier merged 1 commit intoOpenEMS:developfrom
Conversation
iseeberg79
commented
Nov 16, 2025
iseeberg79
commented
- Correction for the smart-mode skip logic: Modbus writes are skipped if the power change is within the tolerance or unchanged, unless the watchdog interval is exceeded.
- Implemented an idle zone: any power within tolerance (i.e. ±50 W per default) is set to 0 to reduce unnecessary battery cycling and inverter wear.
Co-Authored-By: deadrabbit87 <[email protected]>
|
@deadrabbit87 please double check and review |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #3417 +/- ##
=============================================
+ Coverage 59.74% 59.75% +0.01%
Complexity 112 112
=============================================
Files 2870 2870
Lines 124042 124043 +1
Branches 9298 9294 -4
=============================================
+ Hits 74101 74113 +12
+ Misses 47159 47151 -8
+ Partials 2782 2779 -3 🚀 New features to boost your workflow:
|
|
Maybe you should run https://github.com/OpenEMS/openems/blob/develop/tools/prepare-commit.sh to prepare the PR for merging? |
|
Not required for these changes I assume, changes actually nothing Thanks, for reviewing ;-) |
|
@sfeilmeier Just wanted to follow up on this PR. We've been running these changes on two separate instances for about two weeks now without any issues. Is there anything else you'd like to address before merging? Happy to make adjustments if needed. Thanks for your time! |
|
@deadrabbit87 & @iseeberg79 Thank you for your continuous work! |
3 participants
