Edge UI: Use browser Language as Default#3415
Merged
sfeilmeier merged 11 commits intoOpenEMS:developfrom Mar 1, 2026
Merged
Conversation
da-Kai
changed the title
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (22.23%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #3415 +/- ##
=============================================
- Coverage 58.60% 58.59% -0.01%
Complexity 105 105
=============================================
Files 3091 3092 +1
Lines 134005 134011 +6
Branches 9882 9871 -11
=============================================
- Hits 78523 78512 -11
- Misses 52583 52591 +8
- Partials 2899 2908 +9 🚀 New features to boost your workflow:
|
…-browser-language # Conflicts: # ui/src/assets/i18n/de.json # ui/src/assets/i18n/en.json
lukasrgr
requested changes
Dec 1, 2025
Contributor
lukasrgr
left a comment
lukasrgr
left a comment
There was a problem hiding this comment.
Thx for this incremental improvement
…-browser-language
lukasrgr
approved these changes
Feb 25, 2026
sfeilmeier
approved these changes
Mar 1, 2026
| "YESTERDAY": "Gestern" | ||
| "YESTERDAY": "Gestern", | ||
| "NO_LOCAL_DATA_INFO": "Historische Daten sind derzeit lokal nicht verfügbar", | ||
| "NO_LOCAL_DATA_NOTICE": "Bitte besuchen Sie https://github.com/OpenEMS/openems für Updates zu diesem Thema." |
Contributor
There was a problem hiding this comment.
There should probably be a link in OpenEMS environment for this case and use a variable here.
sfeilmeier
added a commit
that referenced
this pull request
Mar 12, 2026
Since #3415 forwarding to Live did not work on local UI Reviewed-by: Lukas Rieger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AuthenticateResponseprovides no language.detoendein Karma tests.Address language issue in #3411