Fix: updated Docker deployment docs (issue #3411)#3412
Fix: updated Docker deployment docs (issue #3411)#3412sfeilmeier merged 6 commits intoOpenEMS:developfrom
Conversation
…I_WEBSOCKET, added language and next steps sections
|
Hi @daandupau @rnicolas |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3412 +/- ##
=============================================
+ Coverage 59.61% 59.63% +0.02%
Complexity 112 112
=============================================
Files 2894 2894
Lines 124658 124658
Branches 9343 9343
=============================================
+ Hits 74304 74323 +19
+ Misses 47534 47524 -10
+ Partials 2820 2811 -9 🚀 New features to boost your workflow:
|
|
@akshith30388 thanks, |
I’m happy to adjust anything needed. Thanks! |
494128e to
927d88e
Compare
|
Hi @da-Kai — thanks for spotting that! The change that removed the leading = from the document title was unintended (it affects the AsciiDoc heading). I’ve reverted that single line so the title is back to: = Deploy OpenEMS Edge to Docker All your other suggestions have been applied and the file has been updated to resolve the conflicts. Could you please re-check and approve the workflow when you have a moment? Thanks a lot for the review and the guidance. |
|
Thanks @da-Kai — good catch. I reverted the accidental removal of the = from the title so the AsciiDoc heading is correct again. All other changes are resolved — please re-check and approve when convenient. Thanks!
________________________________
From: da Kai ***@***.***>
Sent: Tuesday, November 18, 2025 1:21 AM
To: OpenEMS/openems ***@***.***>
Cc: POLA AKSHITH ***@***.***>; Mention ***@***.***>
Subject: Re: [OpenEMS/openems] Fix: updated Docker deployment docs (issue #3411) (PR #3412)
@da-Kai commented on this pull request.
________________________________
In doc/modules/ROOT/pages/edge/deploy/docker.adoc<#3412 (comment)>:
@@ -1,4 +1,4 @@
-= Deploy OpenEMS Edge to Docker
+Deploy OpenEMS Edge to Docker
@akshith30388<https://github.com/akshith30388> i guess this is an unintended change. Besides that, looks good to me
—
Reply to this email directly, view it on GitHub<#3412 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BU5K26VELFJZI6T7IBBKWT335IRLVAVCNFSM6AAAAACL5G6LXWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTINZUGMZTOMRVGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
|
||
| == Changing the Language in the UI | ||
|
|
||
| To change the language in the OpenEMS UI, open the UI in your browser, click on the settings (⚙️) icon in the top-right corner, and select your preferred language. |
There was a problem hiding this comment.
@akshith30388
I don't know how i missed that, in the previous reviews 😅. I like the idea, but the steps described are wrong. There ist no settings (⚙️) icon in the top-right corner
Could you update the instructions to reflect the actual steps to change the UI language?
There was a problem hiding this comment.
Just to point this out - some AI is hallucinating on this here 😂
349c5df to
c22188e
Compare
|
Hi @da-Kai, Thanks for pointing this out! The settings (⚙️) icon reference was incorrect. Language selection is available through the user/profile (avatar) menu Users can choose their preferred language directly from the dropdown The instructions have been corrected accordingly. |
da-Kai
left a comment
There was a problem hiding this comment.
I know LLMs can be helpful, but unfortunately they don’t know the OpenEMS UI 😜
| To change the language in the OpenEMS UI: | ||
|
|
||
| 1. Open the OpenEMS Edge UI in your browser. | ||
| 2. Click the user/profile icon (avatar) in the top-right corner of the UI. |
|
|
||
| 1. Open the OpenEMS Edge UI in your browser. | ||
| 2. Click the user/profile icon (avatar) in the top-right corner of the UI. | ||
| 3. Choose your preferred language from the "Language" dropdown in the profile menu. |
There was a problem hiding this comment.
The dropdown is called "Sprache wählen:" (default) or "Select language:" in english
| 1. Open the OpenEMS Edge UI in your browser. | ||
| 2. Click the user/profile icon (avatar) in the top-right corner of the UI. | ||
| 3. Choose your preferred language from the "Language" dropdown in the profile menu. | ||
| 4. The UI will immediately switch to the selected language (or you may need to reload). |
There was a problem hiding this comment.
Currently a reload will actually reset the language. My PR #3415 would fix this.
| 3. Choose your preferred language from the "Language" dropdown in the profile menu. | ||
| 4. The UI will immediately switch to the selected language (or you may need to reload). | ||
|
|
||
| If helpful, you can add a small screenshot showing the profile menu and language dropdown for clarity. |
33f1a01 to
c22188e
Compare
|
Hi @da-Kai, thanks for the clarifications! I’ve updated the section based on your feedback:
Please let me know if anything else should be adjusted. Thanks again for your detailed review! |
Also right now we are currently seeing PRs with MANY unnecessary changes due to LLMs - but this is probably worth a Discussion on community.openems.io |
Hi @akshith30388, it looks like something might have gone wrong with your last commit, as i see no changes. |
This PR updates the Docker deployment documentation to:
Fixes: #3411