Skip to content

Fix Backend build#3317

Merged
sfeilmeier merged 3 commits intoOpenEMS:developfrom
da-Kai:ci/fix-build
Sep 19, 2025
Merged

Fix Backend build#3317
sfeilmeier merged 3 commits intoOpenEMS:developfrom
da-Kai:ci/fix-build

Conversation

@da-Kai
Copy link
Copy Markdown
Contributor

@da-Kai da-Kai commented Sep 18, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@              Coverage Diff               @@
##             develop    #3317       +/-   ##
==============================================
+ Coverage      26.53%   59.50%   +32.98%     
- Complexity         0      113      +113     
==============================================
  Files            320     2765     +2445     
  Lines           8641   119513   +110872     
  Branches        1334     8892     +7558     
==============================================
+ Hits            2292    71106    +68814     
- Misses          6245    45729    +39484     
- Partials         104     2678     +2574     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@da-Kai da-Kai marked this pull request as draft September 18, 2025 09:01
@parapluplu
Copy link
Copy Markdown
Contributor

parapluplu commented Sep 19, 2025

I'm a bit puzzled by this issue and cannot reproduce it locally.
Seems like this started with merging commit 0c70540 into the develop branch. So I checked that out locally, but there BackendApp.bndrun just stays the same. I skipped chekstyle and unit tests in my gradle build, since I wanted to speed up things. To my understanding it shouldn't affect stuff, but I'll run another build in a fresh workspace with a freshly cloned openems repo in the background now including checkstyle and tests just to be sure.

> git checkout 0c705403dffe68578d38edbd9ce21a82bdb98d20
[... all fine]
> ./gradlew build -x test -x checkstyleAll -x checkstyleMain -x checkstyleTest
[...]
BUILD SUCCESSFUL in 1m 1s
> ./gradlew resolve
> git diff --exit-code io.openems.backend.application/BackendApp.bndrun

last two commands had no output, meaning there's not change.

update:
with a clean workspace and the full build run I still cannot reproduce this:

> ./gradlew build
[...]
BUILD SUCCESSFUL in 10m 36s
> ./gradlew resolve

BUILD SUCCESSFUL in 39s
> git diff --exit-code io.openems.backend.application/BackendApp.bndrun

lower gson version; add okhttp
@da-Kai
Copy link
Copy Markdown
Contributor Author

da-Kai commented Sep 19, 2025

I was unable to reproduce the exact behavior locally either. Perhaps it is a strange Gradle cache issue.

@parapluplu
Copy link
Copy Markdown
Contributor

looks good now, besides the flaky openems ui coverage build. Can you move the pull request out of the draft stage?

@da-Kai da-Kai marked this pull request as ready for review September 19, 2025 09:02
@da-Kai da-Kai requested a review from parapluplu September 19, 2025 09:02
@sfeilmeier
Copy link
Copy Markdown
Contributor

Thanks for fixing. Yes, the issue is, that I forget to update build.bnd in #3309. I will merge ASAP

@sfeilmeier sfeilmeier merged commit 97c453c into OpenEMS:develop Sep 19, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants