Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves the Docker configuration for OpenEMS by setting explicit Apache Felix HTTP host and port settings and adding validation for UI websocket configuration.
- Set Apache Felix HTTP host to 0.0.0.0 and explicit ports for edge (8080) and backend (8079) services
- Add validation check for UI_WEBSOCKET placeholder configuration with error messaging
- Remove localhost restriction to allow external connections in Docker containers
Reviewed Changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/docker/edge/root/etc/s6-overlay/s6-rc.d/svc-openems-edge/run | Set Felix HTTP host to 0.0.0.0 and port to 8080 for edge service |
| tools/docker/backend/root/etc/s6-overlay/s6-rc.d/svc-openems-backend/run | Set Felix HTTP host to 0.0.0.0 and port to 8079 for backend service |
| tools/docker/ui/root/etc/s6-overlay/s6-rc.d/svc-openems-ui/run | Add validation for UI_WEBSOCKET placeholder with error handling |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3262 +/- ##
==============================================
+ Coverage 26.47% 59.25% +32.78%
- Complexity 0 139 +139
==============================================
Files 319 2729 +2410
Lines 8614 118436 +109822
Branches 1334 8753 +7419
==============================================
+ Hits 2280 70162 +67882
- Misses 6232 45644 +39412
- Partials 102 2630 +2528 🚀 New features to boost your workflow:
|
sfeilmeier
approved these changes
Aug 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UI_WEBSOCKETis unchanged