Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files@@ Coverage Diff @@
## develop #3247 +/- ##
=============================================
- Coverage 59.42% 59.35% -0.06%
Complexity 139 139
=============================================
Files 2701 2701
Lines 117464 117464
Branches 8719 8719
=============================================
- Hits 69787 69705 -82
- Misses 45051 45144 +93
+ Partials 2626 2615 -11 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Docker permission issues and improves documentation for the OpenEMS Docker deployment. The changes include replacing cp commands with rsync to ensure proper file ownership, adding dos2unix conversion for cross-platform compatibility, and updating documentation to provide clearer instructions for hostname configuration.
- Replaces
cpcommands withrsync --chown=abc:abcto fix file permission issues - Adds
dos2unixpackage and line ending conversion for cross-platform compatibility - Updates README files and docker-compose.yml to explicitly instruct users to replace hostnames
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/docker/ui/root/etc/s6-overlay/s6-rc.d/init-nginx/run | Replaces cp with rsync for proper file ownership in nginx initialization |
| tools/docker/ui/README.md | Improves formatting with additional spacing around code blocks |
| tools/docker/ui/Dockerfile | Adds dos2unix and rsync packages, implements line ending conversion |
| tools/docker/edge/root/etc/s6-overlay/s6-rc.d/init-openems-config/run | Adds ownership control to rsync command for config initialization |
| tools/docker/edge/docker-compose.yml | Updates UI_WEBSOCKET to use placeholder hostname with clear replacement instructions |
| tools/docker/edge/README.md | Updates URLs to use hostname placeholder and improves documentation formatting |
| tools/docker/edge/Dockerfile | Simplifies package installation and adds dos2unix conversion |
| tools/docker/backend/root/etc/s6-overlay/s6-rc.d/init-openems-config/run | Replaces cp with rsync for both config and metadata file operations |
| tools/docker/backend/docker-compose.yml | Updates UI_WEBSOCKET to use placeholder hostname with replacement instructions |
| tools/docker/backend/README.md | Updates URLs to use hostname placeholder and improves formatting |
| tools/docker/backend/Dockerfile | Simplifies package installation and adds dos2unix conversion |
sfeilmeier
approved these changes
Jul 22, 2025
Contributor
sfeilmeier
left a comment
sfeilmeier
left a comment
There was a problem hiding this comment.
Thanks for your continous improvements! 🤞
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README.mddocker-compose.ymlto explicitly tell users to replace hostname`