SMA Sunny Island - add configurable capacity #3243
Merged
sfeilmeier merged 3 commits intoOpenEMS:developfrom Jul 21, 2025
Merged
SMA Sunny Island - add configurable capacity #3243sfeilmeier merged 3 commits intoOpenEMS:developfrom
sfeilmeier merged 3 commits intoOpenEMS:developfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files@@ Coverage Diff @@
## develop #3243 +/- ##
=============================================
+ Coverage 59.38% 59.39% +0.02%
Complexity 139 139
=============================================
Files 2683 2683
Lines 116650 116651 +1
Branches 8639 8639
=============================================
+ Hits 69256 69276 +20
+ Misses 44780 44754 -26
- Partials 2614 2621 +7 🚀 New features to boost your workflow:
|
clehne
commented
Jul 21, 2025
| ; | ||
| .next(new TestCase() // | ||
| .output(SymmetricEss.ChannelId.CAPACITY, 10_000)) // | ||
| .deactivate(); |
Contributor
Author
There was a problem hiding this comment.
Thanks @sfeilmeier! It should have been possible for me, to add this by myself ;-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be now way to read out the battery capacity on a SMA Sunny Island.
This PR adds a configurable value to the bundle which is then applied to the
SymmetricEss.CAPACITYchannel.The capacity is probably needed for a bunch of other bundles.