fix: remove redundant unsubscribeFromChannels on component destroy to align with edge signal refactor#3242
Merged
sfeilmeier merged 1 commit intoOpenEMS:developfrom Aug 25, 2025
Conversation
… align with edge signal refactor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3242 +/- ##
=============================================
+ Coverage 59.38% 59.39% +0.02%
Complexity 139 139
=============================================
Files 2683 2683
Lines 116650 116648 -2
Branches 8639 8638 -1
=============================================
+ Hits 69256 69267 +11
+ Misses 44780 44769 -11
+ Partials 2614 2612 -2 🚀 New features to boost your workflow:
|
lukasrgr
approved these changes
Aug 25, 2025
sfeilmeier
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR change removes the call to
this.edge.unsubscribeFromChannels()inAbstractFlatWidgetLine'sngOnDestroy()method.Reason
OpenEMS has refactored
Edgeinto a Signal-based global state (Service.currentEdge) after 202504 version edge signal refactor.Components are now pure consumers of edge Signals, without managing channel lifecycle.
Prevents premature unsubscription leading to data loss and inconsistent UI state.
How to reproduce the Error?
Use OpenEMS UI version
2025.4.0or later.