Proposal: addToSum for ElectricityMeter#3238
Closed
sthhs wants to merge 2 commits intoOpenEMS:developfrom
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #3238 +/- ##
==============================================
- Coverage 59.40% 26.87% -32.52%
==============================================
Files 2683 304 -2379
Lines 116693 8204 -108489
Branches 8643 1265 -7378
==============================================
- Hits 69304 2204 -67100
+ Misses 44764 5899 -38865
+ Partials 2625 101 -2524 🚀 New features to boost your workflow:
|
|
This PR has been automatically marked as stale due to inactivity. It will be closed in 7 days if no further activity occurs. |
|
Closing this PR due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes a meter that is located behind another meter should not be considered in the calculation of the production or consumption sum.
With the changes in this PR it is possible to configure a meter to be excluded from the sum calculation by implementing the function addToSum().
Default value is true, so there is no need to change the code for every already existing meter.