Skip to content

Edge2Edge ESS: Energy Calculation#3234

Merged
sfeilmeier merged 3 commits intoOpenEMS:developfrom
opernikus-common:feature/edge2edge-energy-calculation
Jul 13, 2025
Merged

Edge2Edge ESS: Energy Calculation#3234
sfeilmeier merged 3 commits intoOpenEMS:developfrom
opernikus-common:feature/edge2edge-energy-calculation

Conversation

@tsicking
Copy link
Copy Markdown
Contributor

@tsicking tsicking commented Jul 8, 2025

Edge2Edge-ESS did not have energy values before. We decided to calculate them on the master edge, because then we don't have to change the modbus table and don't have to update the software on the slave system.

@tsicking tsicking requested a review from clehne July 8, 2025 11:17
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

❌ Your patch status has failed because the patch coverage (14.29%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3234      +/-   ##
=============================================
+ Coverage      59.35%   59.39%   +0.05%     
  Complexity       139      139              
=============================================
  Files           2681     2681              
  Lines         116561   116617      +56     
  Branches        8636     8638       +2     
=============================================
+ Hits           69168    69255      +87     
+ Misses         44776    44747      -29     
+ Partials        2617     2615       -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@clehne clehne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@sfeilmeier sfeilmeier merged commit 43fdd3a into OpenEMS:develop Jul 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants