[Edge] EVCS Mennekes: replace handling of phase-rotated wiring#3208
Merged
sfeilmeier merged 3 commits intoOpenEMS:developfrom Jul 1, 2025
Merged
[Edge] EVCS Mennekes: replace handling of phase-rotated wiring#3208sfeilmeier merged 3 commits intoOpenEMS:developfrom
sfeilmeier merged 3 commits intoOpenEMS:developfrom
Conversation
Codecov ReportAttention: Patch coverage is ❌ Your patch status has failed because the patch coverage (70.59%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #3208 +/- ##
=============================================
+ Coverage 59.13% 59.15% +0.02%
Complexity 139 139
=============================================
Files 2682 2682
Lines 115850 115840 -10
Branches 8533 8533
=============================================
+ Hits 68501 68512 +11
+ Misses 44787 44770 -17
+ Partials 2562 2558 -4 🚀 New features to boost your workflow:
|
sfeilmeier
approved these changes
Jul 1, 2025
Contributor
sfeilmeier
left a comment
sfeilmeier
left a comment
There was a problem hiding this comment.
Thanks. I did some more cleanup
sfeilmeier
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new approach directly maps the Modbus register values to the appropriate current channels based on the configured phase rotation, which is cleaner and follows the recommended pattern.