Codecov Report

All modified and coverable lines are covered by tests ✅

@@              Coverage Diff              @@
##             develop    #3197      +/-   ##
=============================================
+ Coverage      58.87%   59.09%   +0.22%     
- Complexity       173      181       +8     
=============================================
  Files           2619     2662      +43     
  Lines         113027   114360    +1333     
  Branches        8318     8407      +89     
=============================================
+ Hits           66536    67565    +1029     
- Misses         44000    44266     +266     
- Partials        2491     2529      +38     

@michaelgrill Can you please validate? Shouldn't the mapIfPresent variant also work?

@michaelgrill Can you please validate? Shouldn't the mapIfPresent variant also work?

It doesn't work because mapIfPresent returns null, and therefore forEach throws a NullPointerException. Here is the result of the JUnit test with the old code:

@sfeilmeier
@tsicking is right mapIfPresent returns null if not included in the json (as mentioned in the javadoc). Use mapToOptional or the shortest way would be something like this
json.getOptionalList("recurrenceRules", RecurrenceRule.serializer()).orElse(Collections.emptyList())

@sfeilmeier @tsicking is right mapIfPresent returns null if not included in the json (as mentioned in the javadoc). Use mapToOptional or the shortest way would be something like this json.getOptionalList("recurrenceRules", RecurrenceRule.serializer()).orElse(Collections.emptyList())

Thanks for your quick response. Your suggestion also works and is slightly more elegant, so I changed it accordingly.

Thank you all! 👍🚀