[wip]feat: enable adjustable websocket compression#3196
Closed
miettal wants to merge 3 commits intoOpenEMS:developfrom
Closed
[wip]feat: enable adjustable websocket compression#3196miettal wants to merge 3 commits intoOpenEMS:developfrom
miettal wants to merge 3 commits intoOpenEMS:developfrom
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (45.84%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #3196 +/- ##
=============================================
+ Coverage 59.48% 59.53% +0.06%
Complexity 113 113
=============================================
Files 2765 2765
Lines 119513 119526 +13
Branches 8892 8892
=============================================
+ Hits 71075 71149 +74
+ Misses 45774 45704 -70
- Partials 2664 2673 +9 🚀 New features to boost your workflow:
|
Contributor
Author
miettal
force-pushed
the
feature/enable-adjustable-websocket-compression
branch
from
1b7ccc4 to
57254d6
Compare
Contributor
Author
|
rebased |
miettal
force-pushed
the
feature/enable-adjustable-websocket-compression
branch
from
57254d6 to
324402d
Compare
Contributor
Author
|
rebased |
miettal
force-pushed
the
feature/enable-adjustable-websocket-compression
branch
from
324402d to
8d1de7c
Compare
Contributor
Author
|
rebased |
This PR has been automatically marked as stale due to inactivityIf it is still relevant, please update the PR. Before updating, please review our Contribution Guidelines to ensure all required information is provided. |
This PR has been closed due to inactivityIt was automatically closed because there has been no recent activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From TooTallNate/Java-WebSocket 1.6, the websocket library support specification of compression level.
So this PR introduce compression level adjusable websocket compression function.
But this repo still use 1.5.4 because it has a blocker (compatibility problem, blocking reconnection was not supported).
#2926
But recently blocking reconnection is supported! This freature will released in 1.6.1, I think.
TooTallNate/Java-WebSocket#1465
Currently this PR is in WIP, because waiting 1.6.1 release.