fix: add translation text for technicalName, category, cardinality#3189
Merged
sfeilmeier merged 1 commit intoOpenEMS:developfrom Aug 3, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #3189 +/- ##
==============================================
- Coverage 58.87% 26.91% -31.96%
==============================================
Files 2619 291 -2328
Lines 113027 7791 -105236
Branches 8318 1197 -7121
==============================================
- Hits 66536 2096 -64440
+ Misses 44000 5602 -38398
+ Partials 2491 93 -2398 🚀 New features to boost your workflow:
|
sfeilmeier
approved these changes
Aug 3, 2025
Contributor
sfeilmeier
left a comment
sfeilmeier
left a comment
There was a problem hiding this comment.
Thank you!
NOTE: It's best practice to name translation ids with UPPER_CASE, but we are not yet enforcing it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces localization improvements to the app settings UI by replacing hardcoded strings with translatable keys and updating language files to include the necessary translations.
Localization improvements:
ui/src/app/edge/settings/app/index.component.html: Replaced hardcoded labels like "Technischer Name," "Kategorie," and "Cardinality" with translatable keys (Edge.Config.App.technicalName,Edge.Config.App.category, andEdge.Config.App.cardinality) to support internationalization.Language file updates:
ui/src/assets/i18n/de.json: Added translations for "technicalName," "category," and "cardinality" in German.ui/src/assets/i18n/en.json: Added translations for "technicalName," "category," and "cardinality" in English.ui/src/assets/i18n/ja.json: Added translations for "technicalName," "category," and "cardinality" in Japanese.co-author: @Jasonlee6789 , codex, copilot