fix: drop unused getEditButtonText; add ja text#3188
Merged
sfeilmeier merged 2 commits intoOpenEMS:developfrom Aug 26, 2025
Merged
fix: drop unused getEditButtonText; add ja text#3188sfeilmeier merged 2 commits intoOpenEMS:developfrom
sfeilmeier merged 2 commits intoOpenEMS:developfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3188 +/- ##
==========================================
Coverage ? 59.53%
Complexity ? 113
==========================================
Files ? 2765
Lines ? 119513
Branches ? 8892
==========================================
Hits ? 71142
Misses ? 45697
Partials ? 2674 🚀 New features to boost your workflow:
|
miettal
force-pushed
the
bugfix/use-getEditButtonText
branch
from
775644b to
0bd1cf5
Compare
Contributor
Author
|
rebased |
sfeilmeier
requested changes
Aug 25, 2025
ui/src/app/user/user.component.html
Outdated
| [disabled]="!isEditModeDisabled && !this.form?.formGroup?.dirty"> | ||
| <ion-label>{{isEditModeDisabled ? ('General.EDIT' | translate) :('General.RESET' | | ||
| translate)}}</ion-label> | ||
| <ion-label>{{ getEditButtonText() | translate }}</ion-label> |
Contributor
There was a problem hiding this comment.
Calling functions from an Angular HTML template should be avoided for performance reasons. Instead the getEditButtonText() method seems to be left over and should be deleted.
Contributor
Author
There was a problem hiding this comment.
I see! I removed this function.
// Thank you information. This is very pratical experience for me.
getEditButtonText() is not used and this function obsoluted because performance issue of template rendering.
miettal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a small but meaningful improvement to the user interface by refactoring the logic for determining the edit button text and adding missing translations for Japanese localization.
UI Improvements:
ui/src/app/user/user.component.html: Replaced inline conditional logic for the edit button label with a call to the newgetEditButtonText()method, improving readability and maintainability.Localization Enhancements:
ui/src/assets/i18n/ja.json: Added missing Japanese translations for "EDIT" ("編集") and "RESET" ("リセット") to ensure proper localization.