@deadrabbit87 fyi

Just one Question from my Side - why didn't you use SunSpec?

https://www.photovoltaikforum.com/core/file-download/79166/

I tried initially but it did not work in detail. I know about the models and Kostals abilities. For DC power openEMS actually does not read model 160 (see waiting Fronius PR).

Some implementations seem to need adjustments to deliver the right semantics to be used in UI live/history widgets. For example the meter needed inversion or not all values are available. Probably it's also our actual missing openEMS knowledge which led into errors and our conclusions.

In addition sunspec implemented by Kostal does not allow to control - is read only.

For different installations (KSEM via inverter or direct) it's komplex to re-use.

We ended up by mixing the models, overwriting methods and decided not to go for sunspec at the end, as interpretion of data was not right in any detail.

This way we achieved the implementation to be correct for our different installations and the battery finally to be controllable.

It might be possible using sunspec as well... not in chapter #1 ;-)

Thank you! At first sight it looks very good, even though not all coding guidelines are met yet, I believe (https://openems.github.io/openems.io/openems/latest/contribute/coding-guidelines.html)

I don't know when I have time to do a review. Will appreciate if somebody could do a first detailed review or directly edit.

For reference I am linking the community thread as well: https://community.openems.io/t/kostal-plenticore-hybrid/6772/8

I took some time to fix according to our coding guidelines. I do not own a Kostal Plenticore, so cannot validate functionality. Also I did not read through the entire logic. Some comments on my changes:

• I merged the KOSTAL bundles for PIKO and PLENTICORE into one io.openems.edge.kostal; PIKO might be quite outdated, though.
• Applied Eclipse Autoformat + Organize Imports
• Standardized Factory-PIDs
• Add enabled-check to handleEvent()
• Cleanup unused comments
• Applied the tools/prepare-commit.sh script

I believe modbus definition in KostalGridMeterImpl could be simplified, but did not touch it.

I am merging this PR to avoid it becoming outdated again. If you find future improvements, just place another PR.

Thanks for supporting OpenEMS! 🚀🤘

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ There is a different number of reports uploaded between BASE (5c5cd5b) and HEAD (987113e). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (5c5cd5b)	HEAD (987113e)
java	1	0

@@              Coverage Diff               @@
##             develop    #3118       +/-   ##
==============================================
- Coverage      58.51%   26.88%   -31.63%     
==============================================
  Files           2576      296     -2280     
  Lines         110776     7860   -102916     
  Branches        8167     1205     -6962     
==============================================
- Hits           64805     2112    -62693     
+ Misses         43574     5654    -37920     
+ Partials        2397       94     -2303     

Thank you for the adjustments made and for merging. Took us a lot of time, happy to support the project.

The existing PV-inverter/Meter should get reviewed as I am unsure about superseeding it. Here some comments from others are welcome to be able to decide about. Perhaps the other is supporting other or older hardware.

Happy about initial completion.

Thanks a lot for merging this PR!