Skip to content

FEMS Backports 2025-05-01#3113

Merged
sfeilmeier merged 21 commits intodevelopfrom
feature/fems-backports
May 1, 2025
Merged

FEMS Backports 2025-05-01#3113
sfeilmeier merged 21 commits intodevelopfrom
feature/fems-backports

Conversation

@sfeilmeier
Copy link
Copy Markdown
Contributor

@sfeilmeier sfeilmeier commented May 1, 2025

  • UI

    • UI: use previous update and only for meta new
      • updateAppConfig bugged in edge
      • call updateComponentConfig in the meantime until updateAppConfig is fixed
    • Improve action sheet navigation
      • fixing breadcrumbs order
      • parent for nested children can be set to null initially, allows to seemlessly nest routes
      • nesting for 2 dimension was not working because parents was not set
      • added a new route for the action sheet
    • Add type to "Get Modbus Protocol" file name when downloading Excel sheet
      • Currently when downloading the Modbus protocol by the modal, the file name is "Modbus-undefined-EdgeNr".
      • Added type to modal.html so now it its "Modbus-tcp-EdgeNr".
    • Reapply chartdatalabels plugin
      • fix energy journey chart plugin, was overwritten by y_axis_title_position plugin
    • Fix storage dataset not assigned to axis
      • yAxis was not scaling according to dataset due to never having a dataset assigned
    • Improve new navigation
    • Improvements to EVSE+new navigation
      • Fix tooltips
      • Add Status Chart
      • Fix Unit in Modal (kWh -> Wh)
    • Extend alerting with fault [BETA-APP]
      • Add possibility to set fault alerting in Monitoring
    • Filters and lists style improvements
      • Updated filter and list box styles to use primary color for borders and icons in both light and dark modes.
    • Improve formly-select
  • Edge

    • KEBA P40: fix Exception during activate
      • Improve modified method
    • Edge2Edge Ess: cirular dependency error
      • Error e. g.: Coefficient for [ess0,ALL,ACTIVE] was not found. Ess-Power is not (yet) fully initialized.
      • Circular Dependecy on startup which leads to an exception and _power does not get the ess reference and therefore does not create the initial constraints/coefficients.
        ess -> _power -> ess
      • Could also happen for future ess depending on the startup order in the EdgeApp.bndrun
    • Improve Battery Protection
      • adjusted force charge/discharge parameters
      • adjusted max ever charge/discharge current
      • removed extended volt range and corresponding enum
    • ESS-Power distribution strategy "keep all nearly equal"
      • Distribute the Power while charging and discharging based on the SOC weightage.
    • GoodWe ApplyPowerHandler improvements
      • Refactor GoodWe ApplyPowerHandler to static methods
      • Apply 100 % test coverage
    • Octopus Heat App: fix Factory-ID
    • JsonUtils.getAsBestType(): improve Number Type Resolution for JsonPrimitives
      • Added support for direct mapping of known numeric types (Double, Float, Integer, Long) using a type-based switch.
      • Longs.tryParse and Doubles.tryParse with correct bounds checking to ensure accurate fallback to long, float, or double based on value size.
    • JSCalendar: migration to JsonSerializer
    • EVSE ChargePoint implementation of HardyBarth
    • Time-of-Use-Tariff Controller:
      • First implementation of DISCHARGE_TO_GRID
      • EnergyFlow: finalizeConsumption() before doing further energy distributions
    • EVSE
      • Add Hysteresis for switching between SURPLUS and ZERO
      • Add appearsToBeFullyCharged(): Apply MIN_CURRENT if car appears to be fully charged. Makes no difference in power, but allows the car to start pre-heating, etc.
    • Energy Scheduler v2
      • Add Revenue for Discharge-to-Grid to fitness function
      • Calculate energy from power correctly for periods with different durations
      • Migrate to JsonSerializer

Co-authored-by: Johann Kaufmann [email protected]
Co-authored-by: Michael Grill [email protected]
Co-authored-by: Lukas Rieger [email protected]
Co-authored-by: Hueseyin Sahutoglu [email protected]
Co-authored-by: Pooran Chandrashekaraiah [email protected]
Co-authored-by: Fabian Brandtner [email protected]
Co-authored-by: Stefan Feilmeier [email protected]
Co-authored-by: Sagar Venu [email protected]
Co-authored-by: Anas Shetla [email protected]
Co-authored-by: Sebastian Asen [email protected]
Co-authored-by: Johann Kaufmann [email protected]

sfeilmeier and others added 20 commits May 1, 2025 15:33
- updateAppConfig bugged in edge
- call updateComponentConfig in the meantime until updateAppConfig is fixed

Co-authored-by: Johann Kaufmann <[email protected]>
Reviewed-by: Johann Kaufmann <[email protected]>
Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Michael Grill <[email protected]>
Co-committed-by: Michael Grill <[email protected]>
- Improve modified method

Reviewed-by: Sebastian Asen <[email protected]>
Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Johann Kaufmann <[email protected]>
Co-committed-by: Johann Kaufmann <[email protected]>
- fixing breadcrumbs order
- parent for nested children can be set to null initially, allows to seemlessly nest routes
- nesting for 2 dimension was not working because parents was not set

Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Lukas Rieger <[email protected]>
Co-committed-by: Lukas Rieger <[email protected]>
- Error e. g.: `Coefficient for [ess0,ALL,ACTIVE] was not found. Ess-Power is not (yet) fully initialized.`
- Circular Dependecy on startup which leads to an exception and _power does not get the ess reference and therefore does not create the initial constraints/coefficients.
ess -> _power -> ess
- Could also happen for future ess depending on the startup order in the EdgeApp.bndrun

Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Michael Grill <[email protected]>
Co-committed-by: Michael Grill <[email protected]>
- adjusted force charge/discharge parameters
- adjusted max ever charge/discharge current
- removed extended volt range and corresponding enum

Co-authored-by: Hueseyin Sahutoglu <[email protected]>
Co-authored-by: pooran.c <[email protected]>
Reviewed-by: Michael Grill <[email protected]>
Reviewed-by: Sebastian Asen <[email protected]>
Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Fabian Brandtner <[email protected]>
Co-committed-by: Fabian Brandtner <[email protected]>
…l sheet

- Currently when downloading the Modbus protocol by the modal, the file name is "Modbus-undefined-EdgeNr".
- Added type to modal.html so now it its "Modbus-tcp-EdgeNr".

Reviewed-by: Lukas Rieger <[email protected]>
Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Fabian Brandtner <[email protected]>
Co-committed-by: Fabian Brandtner <[email protected]>
- fix energy journey chart plugin, was overwritten by `y_axis_title_position` plugin

Reviewed-by: Hanna Späth <[email protected]>
Reviewed-by: Sagar Venu <[email protected]>
Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Lukas Rieger <[email protected]>
Co-committed-by: Lukas Rieger <[email protected]>
yAxis was not scaling according to dataset due to never having a dataset assigned

Reviewed-by: Hanna Späth <[email protected]>
Reviewed-by: Sagar Venu <[email protected]>
Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Lukas Rieger <[email protected]>
Co-committed-by: Lukas Rieger <[email protected]>
Distribute the Power while charging and discharging based on the SOC weightage.

Co-authored-by: Fabian Brandtner <[email protected]>
Co-authored-by: Hueseyin Sahutoglu <[email protected]>
Reviewed-by: Fabian Brandtner <[email protected]>
Reviewed-by: Michael Grill <[email protected]>
Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: pooran chandrashekaraiah <[email protected]>
Co-committed-by: pooran chandrashekaraiah <[email protected]>
- Refactor GoodWe ApplyPowerHandler to static methods
- Apply 100 % test coverage

Reviewed-by: Sebastian Asen <[email protected]>
Co-authored-by: Stefan Feilmeier <[email protected]>
- Fix tooltips
- Add Status Chart
- Fix Unit in Modal (kWh -> Wh)

Reviewed-by: Sagar Venu <[email protected]>
- Add possibility to set fault alerting in Monitoring

Co-authored-by: Sagar Venu <[email protected]>
Co-authored-by: Stefan Feilmeier <[email protected]>
Reviewed-by: Hanna Späth <[email protected]>
Reviewed-by: Sagar Venu <[email protected]>
Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Lukas Rieger <[email protected]>
Co-committed-by: Lukas Rieger <[email protected]>
Reviewed-by: Michael Grill <[email protected]>
Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Sagar Venu <[email protected]>
Co-committed-by: Sagar Venu <[email protected]>
…mitives

- Added support for direct mapping of known numeric types (Double, Float, Integer, Long) using a type-based switch.
- Longs.tryParse and Doubles.tryParse with correct bounds checking to ensure accurate fallback to long, float, or double based on value size.

Reviewed-by: Michael Grill <[email protected]>
Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Sagar Venu <[email protected]>
Co-committed-by: Sagar Venu <[email protected]>
- Updated filter and list box styles to use primary color for borders and icons in both light and dark modes.

Reviewed-by: Sagar Venu <[email protected]>
Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Anas Shetla <[email protected]>
Co-committed-by: Anas Shetla <[email protected]>
Co-authored-by: Sebastian Asen <[email protected]>
Reviewed-by: Lukas Rieger <[email protected]>
Reviewed-by: Hanna Späth <[email protected]>
Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Sagar Venu <[email protected]>
Co-committed-by: Sagar Venu <[email protected]>
Co-authored-by: Michael Grill <[email protected]>
Reviewed-by: Michael Grill <[email protected]>
Co-authored-by: Sebastian Asen <[email protected]>
Co-authored-by: Stefan Feilmeier <[email protected]>
Reviewed-by: Stefan Feilmeier <[email protected]>
Co-authored-by: Fenecon <[email protected]>
Co-committed-by: Fenecon <[email protected]>
- Time-of-Use-Tariff Controller:
  - First implementation of DISCHARGE_TO_GRID
  - EnergyFlow: finalizeConsumption() before doing further energy distributions
- EVSE
  - Add Hysteresis for switching between SURPLUS and ZERO
  - Add appearsToBeFullyCharged(): Apply MIN_CURRENT if car appears to be fully charged. Makes no difference in power, but allows the car to start pre-heating, etc.
- Energy Scheduler v2
  - Add Revenue for Discharge-to-Grid to fitness function
  - Calculate energy from power correctly for periods with different durations
  - Migrate to JsonSerializer
@codecov
Copy link
Copy Markdown

codecov bot commented May 1, 2025

Codecov Report

Attention: Patch coverage is 52.31270% with 732 lines in your changes missing coverage. Please review.

❌ Your patch status has failed because the patch coverage (52.32%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #3113      +/-   ##
=============================================
- Coverage      58.70%   58.58%   -0.12%     
- Complexity       159      173      +14     
=============================================
  Files           2556     2576      +20     
  Lines         109801   110776     +975     
  Branches        8048     8167     +119     
=============================================
+ Hits           64450    64883     +433     
- Misses         42991    43483     +492     
- Partials        2360     2410      +50     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sfeilmeier sfeilmeier merged commit cac7276 into develop May 1, 2025
5 of 7 checks passed
@sfeilmeier sfeilmeier deleted the feature/fems-backports branch May 1, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant