fix: clean CI warnings and stabilize tests#78
fix: clean CI warnings and stabilize tests#78Sun-sunshine06 wants to merge 1 commit intoOpenCoworkAI:mainfrom
Conversation
hqhq1025
left a comment
There was a problem hiding this comment.
✅ LGTM — Approve
Lint fixes are correct and don't change behavior. Symlink detection logic (supportsDirectorySymlinks() probe) is sound.
Minor observations (non-blocking)
plugin-runtime-service.test.tstimeout bump to 15s — the underlying mock-based test shouldn't need this. Worth investigating the root cause separately.ChatView.tsxResizeObserver useEffect has duplicateeslint-disable-next-linesuppressionMessageCard.tsxuseMemooncontentBlocksbusts every render during streaming (rawContent changes each time), providing no real optimization benefit- Logger
getLogContentpolling approach is slightly less reliable than the previous streamfinishevent. Acceptable for now but noted.
|
This PR has merge conflicts with the current |
|
Hi @Sun-sunshine06, thanks for the comprehensive CI cleanup work! I've cherry-picked the most valuable parts of this PR into main (commit 5206ba1): Adopted:
Not adopted (with reasons):
Your authorship is preserved via |
Cherry-pick valuable changes from Sun-sunshine06's PR #78: - Use .values() iterator in lima-bridge/wsl-bridge to eliminate unused _id - Add Windows symlink capability detection in dangling-symlink tests - Replace hardcoded paths with path.join and as-any with MountedPath type - Use vi.doUnmock instead of vi.unmock in store-encryption tests
There was a problem hiding this comment.
Findings
- No issues identified in the added/modified lines.
Summary
- Review mode: initial
- No correctness, security, or maintainability regressions were found in the current diff. Residual testing gap: Windows-specific dangling-symlink behavior is still only covered when directory symlinks are available locally in
src/tests/skills/dangling-symlink.test.ts:39, while CI executes tests only onubuntu-latestin.github/workflows/ci.yml:16.
Testing
- Not run (automation)
Open Cowork Bot
Summary\n- clean the remaining lint warnings in main, renderer, and sandbox modules\n- make credential, path resolver, logger, and plugin runtime tests less brittle across platforms and slower CI runs\n- skip directory symlink-specific assertions when the local Windows environment cannot create symlinks\n\n## Verification\n- npm run lint\n- npm run typecheck\n- npm run test:coverage