feat(core): dashboard ambient signals directive#89
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Findings
- [Major] Prompt rule conflict: requires
setIntervalwhile global output rules prohibit JS animation loops — this creates contradictory instructions and can cause generated artifacts to violate system constraints. Evidencepackages/core/src/prompts/index.ts:417(same text also added atpackages/core/src/prompts/craft-directives.v1.txt:97), conflicting with existing rule in the same prompt that says motion must be CSS-only and no JS loops.
Suggested fix: -
- A live clock in the top-right of the page header: HH:MM:SS in tabular-nums font, updated each second via setInterval, with the current date below in smaller secondary text.
-
- A clock-like status in the top-right of the page header: HH:MM:SS in tabular-nums styling, with the current date below in smaller secondary text; avoid JS timer loops unless explicitly requested.
Questions
- Not found in repo/docs:
docs/VISION.mdanddocs/PRINCIPLES.mdare unavailable in this checkout. Should this CI job mount internaldocs/so policy checks can be fully validated?
Summary
- Review mode: initial
- 1 major issue found in this diff: newly added dashboard directive conflicts with existing no-JS-loop prompt rule and may produce non-compliant artifacts.
Testing
- Not run (automation)
open-codesign Bot
|
|
||
| - A "LIVE" pill badge in the top-right corner of any chart card showing real-time data. Pill is small (font 10-11px), accent color border 1px, padding 2x6px, border-radius 999. | ||
| - A status indicator near the page title: a small green dot (8px diameter, accent color, animated pulse keyframe) followed by "SYSTEM ONLINE" or "LIVE" in 11px uppercase tracked text. | ||
| - A live clock in the top-right of the page header: HH:MM:SS in tabular-nums font, updated each second via setInterval, with the current date below in smaller secondary text. |
Contributor
There was a problem hiding this comment.
[Major] This line mandates setInterval, but the same prompt already forbids JS animation loops (CSS-only motion). Please rewrite this cue to avoid requiring a JS timer loop, or explicitly carve out a narrow exception for clocks to keep instructions consistent.
The "no JS animation loops" output rule conflicted with the dashboard ambient signals directive that requires a live clock via setInterval. Make the live clock an explicit, single permitted exception (one setInterval(updateClock, 1000)) and forbid chaining other animations onto it. Update output-rules to reference the exception so the model sees a coherent set of rules.
Contributor
There was a problem hiding this comment.
Findings
- None.
Summary
- Review mode: follow-up after new commits
- No issues found in added/modified lines of this update.
- Residual risk: prompt-behavior changes are only partially covered by one added assertion (
composeSystemPromptcontains dashboard ambient-signal text). Not found in repo/docs:docs/VISION.mdanddocs/PRINCIPLES.mdin this checkout, so policy cross-check was limited toCLAUDE.mdand the changed files.
Testing
- Not run (automation)
open-codesign Bot
This was referenced Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dashboard 缺 LIVE pill / 实时时钟 / KPI 色条。craft-directives §dashboard substitute 末尾追加 ambient signals 子节。