Findings

• [Major] Disabled-reason tooltip copy bypasses i18n, causing locale regression (zh-CN users will still see English in these newly added tooltips). Evidence: apps/desktop/src/renderer/src/components/Settings.tsx:375, apps/desktop/src/renderer/src/onboarding/ChooseModel.tsx:98, apps/desktop/src/renderer/src/onboarding/PasteKey.tsx:227, apps/desktop/src/renderer/src/onboarding/Welcome.tsx:37
  Suggested fix:

  const t = useT();
  <Tooltip
    label={disabled ? t('disabledReason.enterApiKeyToValidate') : undefined}
    side="top"
  >
    ...
  </Tooltip>

• [Minor] The new Tooltip early-return branch has no automated coverage, so regressions (rendering wrappers when label is undefined / changed hover behavior) may slip through. Evidence: packages/ui/src/components/Tooltip.tsx:15
  Suggested fix:

  it('renders children without tooltip chrome when label is undefined', () => {
    render(<Tooltip label={undefined}><button>Send</button></Tooltip>);
    expect(screen.getByRole('button', { name: 'Send' })).toBeInTheDocument();
    expect(screen.queryByRole('tooltip')).toBeNull();
  });

Summary

• Review mode: initial
• Found 2 issues in the latest head diff, including one localization regression tied to newly added disabled-state tooltip text.
• docs/VISION.md and docs/PRINCIPLES.md: Not found in repo/docs.

Testing

• Not run (automation)

open-codesign Bot

Findings

• [Minor] New Tooltip fallback branch has no unit coverage, so regressions in wrapper/hover behavior can slip in unnoticed across all newly wrapped disabled-button states. Evidence packages/ui/src/components/Tooltip.tsx:15
  Suggested fix:

  import { render, screen } from '@testing-library/react';
  import { Tooltip } from './Tooltip';
  
  it('renders children without tooltip when label is undefined', () => {
    render(
      <Tooltip label={undefined}>
        <button type="button">Send</button>
      </Tooltip>,
    );
  
    expect(screen.getByRole('button', { name: 'Send' })).toBeInTheDocument();
    expect(screen.queryByRole('tooltip')).toBeNull();
  });

Summary

• Review mode: follow-up after new commits
• Found 1 issue in the latest head diff.
• docs/VISION.md and docs/PRINCIPLES.md: Not found in repo/docs.

Testing

• Not run (automation)

open-codesign Bot

Findings

• [Major] Disabled tooltip reasons are not keyboard-accessible, so the new disabled-state guidance is effectively mouse-only. The tooltip is shown only via group-hover / group-focus-within, but its wrapper is a plain span that cannot receive focus. Evidence packages/ui/src/components/Tooltip.tsx:17, packages/ui/src/components/Tooltip.tsx:21.
  Suggested fix:

  import { useId, type ReactNode } from 'react';
  
  export function Tooltip({ label, side = 'bottom', children }: TooltipProps) {
    const tooltipId = useId();
    if (!label) return <>{children}</>;
  
    return (
      <span
        className="relative inline-flex group"
        tabIndex={0}
        aria-describedby={tooltipId}
      >
        {children}
        <span id={tooltipId} role="tooltip" className={`... group-hover:opacity-100 group-focus-within:opacity-100 ...`}>
          {label}
        </span>
      </span>
    );
  }

Summary

• Review mode: follow-up after new commits
• Found 1 issue in the latest head diff.
• docs/VISION.md: Not found in repo/docs.
• docs/PRINCIPLES.md: Not found in repo/docs.

Testing

• Not run (automation)

open-codesign Bot

Findings

• [Major] Tooltip now makes every wrapped control add an extra keyboard tab stop because the wrapper is always focusable (tabIndex={0}), even when the child control is enabled and already keyboard-focusable. This degrades keyboard navigation order across existing always-enabled tooltip usage and is directly caused by the new global wrapper behavior. Evidence packages/ui/src/components/Tooltip.tsx:24.
  Suggested fix:

  import { isValidElement, useId, type ReactNode } from 'react';
  
  export function Tooltip({ label, side = 'bottom', children }: TooltipProps) {
    const tooltipId = useId();
    if (!label) return <>{children}</>;
  
    const childDisabled =
      isValidElement<{ disabled?: boolean }>(children) && Boolean(children.props.disabled);
  
    return (
      <span
        className="relative inline-flex group focus:outline-none focus-visible:ring-2 focus-visible:ring-[var(--color-focus-ring)] rounded-[var(--radius-sm)]"
        tabIndex={childDisabled ? 0 : undefined}
        aria-describedby={childDisabled ? tooltipId : undefined}
      >
        {children}
        <span id={tooltipId} role="tooltip" className={`... group-hover:opacity-100 group-focus-within:opacity-100 ...`}>
          {label}
        </span>
      </span>
    );
  }

Summary

• Review mode: follow-up after new commits
• Found 1 issue in the latest head diff.
• docs/VISION.md: Not found in repo/docs.
• docs/PRINCIPLES.md: Not found in repo/docs.

Testing

• Not run (automation)

open-codesign Bot

Findings

• No high-confidence issues found in added/modified lines.

Summary

• Review mode: follow-up after new commits
• No blocking/major/minor issues identified in the latest head diff.
• docs/VISION.md: Not found in repo/docs.
• docs/PRINCIPLES.md: Not found in repo/docs.
• Residual risk: broad UI behavior across all tooltip callsites cannot be fully validated here because runtime tests were not executable in this environment.

Testing

• Not run (automation): pnpm is unavailable in this runner (pnpm: command not found).

open-codesign Bot