Findings

• [Major] Escape key closes the entire Settings page when Command Palette is open, instead of dismissing the palette first. This changes expected modal/overlay priority and can cause accidental navigation loss while issuing commands. Evidence apps/desktop/src/renderer/src/App.tsx:70.
  Suggested fix:

  {
    combo: 'escape',
    handler: () => {
      if (commandPaletteOpen) closeCommandPalette();
      else if (view === 'settings') setView('workspace');
    },
    preventDefault: false,
  }

Summary

• Review mode: initial
• One major regression found in Escape handling priority.
• Required context docs docs/VISION.md and docs/PRINCIPLES.md: Not found in repo/docs.

Testing

• Not run (automation)

open-codesign Bot

Findings

• [Minor] Locale persistence now has a silent fallback when the bridge is missing, so a broken preload can make the UI switch language without actually saving it. That hides the failure instead of surfacing it, which conflicts with the repo's no-silent-fallback rule. Evidence apps/desktop/src/renderer/src/components/Settings.tsx:777 and apps/desktop/src/renderer/src/components/Settings.tsx:802.
  Suggested fix:

  export async function applyLocaleChange(
    locale: string,
    localeApi: { set: (locale: string) => Promise<string> },
  ): Promise<string> {
    const persisted = await localeApi.set(locale);
    return applyLocale(persisted);
  }
  
  async function handleLocaleChange(v: string) {
    try {
      if (!window.codesign?.locale) throw new Error('Locale bridge unavailable');
      const applied = await applyLocaleChange(v, window.codesign.locale);
      setLocale(applied);
    } catch (err) {
      ...
    }
  }

Summary

• Review mode: follow-up after new commits
• Required context docs docs/VISION.md and docs/PRINCIPLES.md: Not found in repo/docs.
• One minor issue found; no other high-confidence regressions in the touched renderer flow.

Testing

• Not run (automation)
• Vitest coverage was added for the store/settings helpers, but I did not find Playwright coverage for the renderer-level settings navigation or locale switch.

open-codesign Bot

Findings

• [Minor] Newly introduced Settings strings bypass i18n, so non-English users can still see English text and the new locale error keys added in this PR remain unused. Evidence: apps/desktop/src/renderer/src/components/Settings.tsx:810, apps/desktop/src/renderer/src/components/Settings.tsx:1132, packages/i18n/src/locales/en.json:191, packages/i18n/src/locales/zh-CN.json:191.
  Suggested fix:

  const t = useT();
  
  pushToast({
    variant: 'error',
    title: t('errors.localePersistFailed'),
    description: t('errors.rendererDisconnected'),
  });
  
  <button aria-label={t('navigation.backToWorkspace')}>
    {t('navigation.workspace')}
  </button>

Summary

• Review mode: follow-up after new commits
• 1 minor issue found in changed lines.
• docs/VISION.md and docs/PRINCIPLES.md: Not found in repo/docs in this checkout.

Testing

• Not run (automation).

open-codesign Bot

Findings

• [Minor] Full-page Settings header introduces hardcoded English text, so locale switching remains partially untranslated in this new flow. Evidence: apps/desktop/src/renderer/src/components/Settings.tsx:1140, apps/desktop/src/renderer/src/components/Settings.tsx:1143.
  Suggested fix:

  const t = useT();
  
  <button aria-label={t('settings.backToWorkspace')}>
    <ArrowLeft className="w-4 h-4" />
    {t('settings.workspace')}
  </button>

Summary

• Review mode: follow-up after new commits
• 1 minor issue found in changed lines.
• docs/VISION.md and docs/PRINCIPLES.md: Not found in repo/docs.

Testing

• Not run (automation).

open-codesign Bot

Findings

• No high-confidence issues found in added/modified lines.

Summary

• Review mode: follow-up after new commits
• No issues found in the latest diff.
• docs/VISION.md and docs/PRINCIPLES.md: Not found in repo/docs.
• Residual risk: UI-level regressions in full-page settings flow are only partially covered by unit tests (no E2E signal in this run).

Testing

• Not run (automation)

open-codesign Bot

Findings

• No high-confidence issues found in added/modified lines.

Summary

• Review mode: follow-up after new commits
• No issues found in the latest diff.
• docs/VISION.md and docs/PRINCIPLES.md: Not found in repo/docs.
• Residual risk: full-page Settings flow still lacks Playwright/E2E coverage for keyboard navigation and view transitions (Mod+,, Esc, command palette open-settings action).

Testing

• Not run (automation)

open-codesign Bot