Findings

• [Blocker] Hardcoded English copy breaks i18n flow and regresses localized UX — this replaces translation keys with literal strings in user-facing UI, so non-English users will see untranslated content. Evidence: apps/desktop/src/renderer/src/components/Sidebar.tsx:202, apps/desktop/src/renderer/src/components/TopBar.tsx:37, apps/desktop/src/renderer/src/preview/EmptyState.tsx:12
  Suggested fix:

  import { useT } from '@open-codesign/i18n';
  
  const t = useT();
  placeholder={t('chat.placeholder')}
  title={t('topbar.byok.title')}
  <Tooltip label={t('topbar.byok.spendingTooltip')}>
  // starter labels/prompts from i18n keys, e.g. t('demos.pitchDeck.title')

• [Major] New badge styles introduce hardcoded spacing/font sizes instead of packages/ui tokens — this violates the project UI constraint and makes future token-driven theming inconsistent. Evidence: apps/desktop/src/renderer/src/components/TopBar.tsx:36, apps/desktop/src/renderer/src/components/TopBar.tsx:40, apps/desktop/src/renderer/src/components/TopBar.tsx:51
  Suggested fix:

  <div className="... px-[var(--space-3)] py-[var(--space-1)] ...">
    <span className="text-[var(--font-size-body-xs)] ...">...</span>
    <span className="w-[1px] h-[var(--space-3)] ..." aria-hidden="true" />
    <span className="text-[var(--font-size-body-xs)] ...">...</span>
  </div>

• [Minor] No test updates for newly introduced rendering logic and copy paths — this adds new conditional UI behavior (ByokBadge) and starter-card interactions without corresponding Vitest coverage, increasing regression risk. Evidence: apps/desktop/src/renderer/src/components/TopBar.tsx:13, apps/desktop/src/renderer/src/preview/EmptyState.tsx:10
  Suggested fix:

  // TopBar.test.tsx
  it('shows BYOK badge when provider/model are configured', () => {
    // arrange store with provider+model and assert badge text is rendered
  });
  
  // EmptyState.test.tsx
  it('calls onPickStarter with selected starter prompt', async () => {
    // click starter card and assert callback payload
  });

Summary

• Review mode: initial
• 3 issues found in changed lines: 1 blocker (i18n regression), 1 major (token constraint violation), 1 minor (missing tests for new behavior).
• docs/VISION.md and docs/PRINCIPLES.md: Not found in repo/docs (per this checkout), so their latest internal guidance could not be re-validated here.

Testing

• Not run (automation)

open-codesign Bot

Findings

• [Blocker] Starter prompts are now hardcoded English strings, which regresses localized generation behavior for non-English users and bypasses i18n prompt resources. Evidence apps/desktop/src/renderer/src/preview/EmptyState.tsx:16.
  Suggested fix:

  interface StarterCard {
    labelKey: string;
    promptKey: string;
  }
  
  const STARTER_CARDS: StarterCard[] = [
    { labelKey: 'emptyState.starters.landing', promptKey: 'emptyState.prompts.landing' },
    // ...
  ];
  
  onClick={() => onPickStarter(t(card.promptKey))}

• [Major] BYOK badge still contains hardcoded English UI copy (title, tooltip label), so Chinese locale users will see untranslated text. Evidence apps/desktop/src/renderer/src/components/TopBar.tsx:38, apps/desktop/src/renderer/src/components/TopBar.tsx:50.
  Suggested fix:

  <div title={t('topbar.byokTitle')}>
    <Tooltip label={t('topbar.byokSpendTooltip')}>

• [Major] BYOK badge uses hardcoded spacing/sizing values instead of UI tokens (px-2.5, py-1, text-[11px], h-3, ml-1), violating the token-only UI constraint. Evidence apps/desktop/src/renderer/src/components/TopBar.tsx:37, apps/desktop/src/renderer/src/components/TopBar.tsx:41, apps/desktop/src/renderer/src/components/TopBar.tsx:47, apps/desktop/src/renderer/src/components/TopBar.tsx:57.
  Suggested fix:

  className="... px-[var(--space-3)] py-[var(--space-1)] ..."
  className="text-[var(--font-size-body-xs)] ..."
  <span className="w-[1px] h-[var(--space-3)] ..." />
  <span className="ml-[var(--space-1)] ..." />

• [Minor] New rendering branches were added (ByokBadge, starter-card prompt wiring) without corresponding tests, leaving regression risk for visibility/localization/callback behavior. Evidence apps/desktop/src/renderer/src/components/TopBar.tsx:13, apps/desktop/src/renderer/src/preview/EmptyState.tsx:12.
  Suggested fix:

  it('renders BYOK badge only when provider and model are configured', () => {
    // assert hidden when missing config, visible when present
  });
  
  it('uses localized starter prompt text when starter card is clicked', async () => {
    // assert onPickStarter receives localized prompt from i18n key
  });

Summary

• Review mode: follow-up after new commits
• 4 issues found in changed lines: 1 blocker, 2 major, 1 minor.
• docs/VISION.md and docs/PRINCIPLES.md: Not found in repo/docs.

Testing

• Not run (automation)

open-codesign Bot

Findings

• [Major] BYOK badge still ships untranslated English UI copy, which causes locale inconsistency in non-English sessions. Evidence apps/desktop/src/renderer/src/components/TopBar.tsx:38, apps/desktop/src/renderer/src/components/TopBar.tsx:50.
  Suggested fix:

  <div title={t('topbar.byokTitle')}>
    <Tooltip label={t('topbar.byokSpendTooltip')}>

• [Blocker] New BYOK badge uses hardcoded sizing/spacing values (px-2.5, py-1, text-[11px], mx-1, h-3, ml-1) in app code, which violates the token-only UI constraint in CLAUDE.md. Evidence apps/desktop/src/renderer/src/components/TopBar.tsx:37, apps/desktop/src/renderer/src/components/TopBar.tsx:41, apps/desktop/src/renderer/src/components/TopBar.tsx:43, apps/desktop/src/renderer/src/components/TopBar.tsx:47, apps/desktop/src/renderer/src/components/TopBar.tsx:57.
  Suggested fix:

  className="... px-[var(--space-3)] py-[var(--space-1)] ..."
  className="text-[var(--font-size-body-xs)] ..."
  <span className="mx-[var(--space-1)] ...">·</span>
  <span className="w-px h-[var(--space-3)] ..." aria-hidden="true" />
  <span className="ml-[var(--space-1)] ...">{t('topbar.spendThisWeek')}</span>

• [Minor] New behavior paths were added without focused tests (ByokBadge visibility + localized starter prompt callback), leaving regression risk for i18n and conditional rendering. Evidence apps/desktop/src/renderer/src/components/TopBar.tsx:13, apps/desktop/src/renderer/src/preview/EmptyState.tsx:56.
  Suggested fix:

  it('renders BYOK badge only when provider and model are configured', () => {
    // assert hidden when provider/model missing, visible otherwise
  });
  
  it('passes localized starter prompt text on card click', async () => {
    // assert onPickStarter receives t(starterPrompts.*)
  });

Summary

• Review mode: follow-up after new commits
• 3 issues found in changed lines: 1 blocker, 1 major, 1 minor.
• docs/VISION.md and docs/PRINCIPLES.md: Not found in repo/docs.

Testing

• Not run (automation)

open-codesign Bot

Findings

• [Blocker] Token-only UI constraint is still violated by newly introduced hardcoded spacing/size values (px-2.5, py-1, text-[11px], mx-1, h-3, ml-1, hover:-translate-y-[2px]) in new UI code, which conflicts with the project rule that UI values must come from packages/ui tokens. Evidence apps/desktop/src/renderer/src/components/TopBar.tsx:37, apps/desktop/src/renderer/src/components/TopBar.tsx:41, apps/desktop/src/renderer/src/components/TopBar.tsx:43, apps/desktop/src/renderer/src/components/TopBar.tsx:47, apps/desktop/src/renderer/src/components/TopBar.tsx:57, apps/desktop/src/renderer/src/preview/EmptyState.tsx:63.
  Suggested fix:

  className="... px-[var(--space-3)] py-[var(--space-1)] ..."
  className="text-[var(--font-size-body-xs)] ..."
  <span className="mx-[var(--space-1)] ...">·</span>
  <span className="w-px h-[var(--space-3)] ..." aria-hidden="true" />
  <span className="ml-[var(--space-1)] ...">{t('topbar.spendThisWeek')}</span>
  // In EmptyState:
  className="... hover:-translate-y-[var(--space-0_5)] ..."

• [Minor] New behavior branches are still untested (ByokBadge conditional render + starter prompt callback wiring), leaving regression risk for i18n and visibility logic. Evidence apps/desktop/src/renderer/src/components/TopBar.tsx:20, apps/desktop/src/renderer/src/preview/EmptyState.tsx:56.
  Suggested fix:

  it('renders BYOK badge only when provider and model are configured', () => {
    // assert hidden when provider/model missing, visible otherwise
  });
  
  it('passes localized starter prompt to onPickStarter', async () => {
    // click starter card and assert callback received t(starterPrompts.*)
  });

Summary

• Review mode: follow-up after new commits
• 2 issues found in changed lines: 1 blocker, 1 minor.
• docs/VISION.md and docs/PRINCIPLES.md: Not found in repo/docs.

Testing

• Not run (automation)

open-codesign Bot

Findings

• [Blocker] Token-only UI constraint is violated by newly added hardcoded spacing utilities in EmptyState (px-8, py-12, gap-8, space-y-3, gap-3). This introduces non-token UI values in changed lines and conflicts with the project rule that UI values must come from packages/ui tokens. Evidence apps/desktop/src/renderer/src/preview/EmptyState.tsx:35, apps/desktop/src/renderer/src/preview/EmptyState.tsx:36, apps/desktop/src/renderer/src/preview/EmptyState.tsx:38, apps/desktop/src/renderer/src/preview/EmptyState.tsx:51.
  Suggested fix:

  <div className="h-full flex items-center justify-center px-[var(--space-8)] py-[var(--space-12)]">
    <div className="w-full max-w-xl flex flex-col items-center gap-[var(--space-8)]">
      <div className="text-center space-y-[var(--space-3)]">
      ...
      <div className="w-full grid grid-cols-2 gap-[var(--space-3)]">

• [Major] Importing @open-codesign/ui at app bootstrap to load fonts pulls the package root module graph instead of a font-only entrypoint, which increases initial renderer work and bundle surface on startup. packages/ui/src/index.ts now has side effects and component re-exports, so this import is broader than intended. Evidence apps/desktop/src/renderer/src/main.tsx:2, packages/ui/src/index.ts:2.
  Suggested fix:

  // packages/ui/package.json
  {
    "exports": {
      ".": "./src/index.ts",
      "./fonts": "./src/fonts.ts",
      "./tokens.css": "./src/tokens.css",
      "./preset": "./src/preset.ts"
    }
  }
  
  // apps/desktop/src/renderer/src/main.tsx
  import '@open-codesign/ui/fonts';

Summary

• Review mode: follow-up after new commits
• 2 issues found in changed lines: 1 blocker, 1 major.
• docs/VISION.md and docs/PRINCIPLES.md: Not found in repo/docs.

Testing

• Not run (automation)
• Missing coverage for new behavior in this diff (suggest adding Vitest tests for ByokBadge visibility/labels and starter-card callback wiring in EmptyState).

open-codesign Bot

Findings

• [Major] Renderer bootstrap imports the package root (@open-codesign/ui) only for side effects, which pulls the root UI module graph at startup instead of a font-only entrypoint. This increases initial bundle surface and startup work on the hot path. Evidence apps/desktop/src/renderer/src/main.tsx:2, packages/ui/src/index.ts:1
  Suggested fix:

  // packages/ui/package.json
  {
    "exports": {
      ".": "./src/index.ts",
      "./fonts": "./src/fonts.ts",
      "./tokens.css": "./src/tokens.css",
      "./preset": "./src/preset.ts"
    }
  }
  
  // apps/desktop/src/renderer/src/main.tsx
  import '@open-codesign/ui/fonts';

Summary

• Review mode: follow-up after new commits
• 1 issue found in changed lines (Major).
• docs/VISION.md and docs/PRINCIPLES.md: Not found in repo/docs.
• Residual risk: no evidence in this diff of install-size measurement after adding three font packages.

Testing

• Not run (automation)
• Missing coverage for new UI behavior in changed files (suggest Vitest coverage for ByokBadge visibility/label mapping and EmptyState starter-card callback wiring).

open-codesign Bot

Findings

• [Minor] Duplicate font side-effect loading path increases maintenance risk and can create redundant CSS/font side-effects in bundling pipelines, evidence apps/desktop/src/renderer/src/main.tsx:2 and packages/ui/src/index.ts:2.
  Suggested fix:

  // packages/ui/src/index.ts
  // remove implicit global side effect from package root
  export { Button } from './components/Button';
  // ...
  
  // apps/desktop/src/renderer/src/main.tsx
  // keep one explicit app-level import
  import '@open-codesign/ui/fonts';

Summary

• Review mode: follow-up after new commits
• 1 minor issue found in modified lines.
• Constraint checks on this diff: no direct provider SDK imports found, UI tokens usage is substantially improved, production dependency count remains within the stated budget (26 <= 30).
• Not found in repo/docs: docs/VISION.md, docs/PRINCIPLES.md in this checkout, so those docs could not be revalidated here.

Testing

• Not run (automation).
• Coverage gap: no new Vitest/Playwright tests for TopBar/EmptyState UI behavior introduced in this diff.

open-codesign Bot

Findings

• No blocking/major/minor issues found in the added/modified lines of this diff.

Summary

• Review mode: follow-up after new commits
• No issues found in modified lines for correctness, security, regressions, or hard-constraint compliance.
• Not found in repo/docs: docs/VISION.md, docs/PRINCIPLES.md in this checkout.

Testing

• Not run (automation).
• Coverage gap: UI behavior introduced in this PR (ByokBadge, EmptyState starter-card interactions, tokenized style regressions in Sidebar) still lacks targeted Vitest/Playwright assertions in this diff.

open-codesign Bot

Findings

• No blocking/major/minor issues found in added/modified lines of this diff.

Summary

• Review mode: follow-up after new commits
• No issues found in modified lines for correctness, security (OWASP Top 10), regressions, data-loss risk, performance, maintainability, or hard-constraint compliance.
• Not found in repo/docs: docs/VISION.md, docs/PRINCIPLES.md.
• Residual risk: no tests were added in this diff for new ByokBadge behavior and EmptyState starter-card interactions.

Testing

• Not run (automation).
• Suggested: add Vitest coverage for ByokBadge rendering conditions and model-label formatting, plus Playwright checks for EmptyState starter-card click-to-prompt flow in both locales.

open-codesign Bot