[codex] hide Ollama until manually added#170
Merged
Sun-sunshine06 merged 1 commit intoOpenCoworkAI:mainfrom Apr 22, 2026
Merged
[codex] hide Ollama until manually added#170Sun-sunshine06 merged 1 commit intoOpenCoworkAI:mainfrom
Sun-sunshine06 merged 1 commit intoOpenCoworkAI:mainfrom
Conversation
Signed-off-by: HUANG <[email protected]>
Contributor
There was a problem hiding this comment.
Findings
- None.
Summary
- Review mode: initial
- No high-confidence issues found in added/modified lines of the latest diff.
- Residual risk: renderer coverage for the new Add Provider -> Ollama interaction appears thin in this checkout (
apps/desktop/src/renderer/src/components/Settings.test.tscurrently exercises locale helper logic only), so UI wiring regressions (menu disabled-state/click flow/toast) may go uncaught.
Testing
- Not run (automation)
- Suggested tests: add a renderer-level test for Add Provider menu Ollama action (invokes
settings.addProviderwith emptyapiKey, then refreshes rows), plus a disabled-state test when Ollama already exists.
open-codesign Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #159 by making Ollama opt-in in Settings.
Ollama (local)no longer appears as a default provider row on fresh configs; users can add it explicitly from the Add provider menu, and the keyless provider is persisted without writing an empty secret.Type of change
Linked issue
Closes #159
Root cause
toProviderRows()always injected keyless builtin providers into the rendered row set. Because Ollama is the only builtin withrequiresApiKey: false, Settings showed it even when the user had never added or configured it.What changed
Checklist
CLAUDE.mdbefore startingdocs/VISION.mdanddocs/PRINCIPLES.mdbefore starting (not present in this local checkout;docs/only containsdocs/research/)git commit -s)pnpm changeset) because behavior changedPRINCIPLES §5b checks
Validation
corepack pnpm --filter @open-codesign/desktop exec vitest run src/main/provider-settings.test.ts src/main/onboarding-ipc.test.ts src/renderer/src/components/Settings.test.ts— 57 passedcorepack pnpm --filter @open-codesign/desktop typecheck— passedcorepack pnpm lint— passedgit diff --check— passedI also attempted the full desktop test suite on Windows. It is currently blocked by environment/platform issues unrelated to this change: missing
better-sqlite3native binding after dependency install, POSIX/tmppath expectations on Windows, and symlink permission failures.Screenshots / recordings (UI changes)
Not attached; this is a small Settings menu behavior change.