fix(desktop): restore add-menu tooltip behavior and labels#156
Merged
Sun-sunshine06 merged 3 commits intoOpenCoworkAI:mainfrom Apr 22, 2026
Merged
fix(desktop): restore add-menu tooltip behavior and labels#156Sun-sunshine06 merged 3 commits intoOpenCoworkAI:mainfrom
Sun-sunshine06 merged 3 commits intoOpenCoworkAI:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Findings
- None.
Summary
- Review mode: initial
- No high-confidence issues found on added/modified lines in the latest diff.
- Residual risk/testing gap: runtime validation was not executed in this environment because
pnpmis unavailable; review is based on static diff and source inspection only. docs/VISION.mdanddocs/PRINCIPLES.md: Not found in repo/docs for this workspace, so hard-constraint cross-checks usedCLAUDE.mdand changed files only.
Testing
- Not run (automation):
pnpmnot available in this runner. Suggested:pnpm --filter @open-codesign/ui test -- Tooltipand desktop smoke to verify tooltip styling in renderer build.
open-codesign Bot
Sun-sunshine06
approved these changes
Apr 22, 2026
Collaborator
Sun-sunshine06
left a comment
There was a problem hiding this comment.
Reviewed locally: tooltip scoped-group fix, Tailwind @source inclusion, and i18n additions look correct. Tooltip tests pass and desktop typecheck passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the add-menu tooltip in the desktop composer.
It does three things:
packages/ui/srcenandzh-CNProblem
From the user’s perspective, the bug showed up in two ways:
+trigger itself was not being hoveredHow to Reproduce
+trigger.Root Cause
The add-menu tooltip regressed for two separate reasons:
Tooltipcomponent stopped using an isolated hover scope, which made the composer and tooltip hover behavior interfere with each other.packages/ui/src, so the shared tooltip's named group variants were not emitted into the app CSS.sidebar.chat.addMenu.triggertranslation key was missing, so the add-menu trigger had no proper user-facing tooltip label.What Changed
Tooltip behavior
Tooltipcomponent back to named Tailwind groups viagroup/tooltipgroup-hover/tooltip:opacity-100group-focus-within/tooltip:opacity-100group-focus/tooltip:opacity-100Tailwind source detection
@sourceentry in the desktop renderer CSS so the renderer build scanspackages/ui/srci18n
sidebar.chat.addMenu.triggerinensidebar.chat.addMenu.triggerinzh-CNDCO
User Impact
+add-menu trigger shows a tooltip againValidation
turbo run testvia the repository commit hookpnpm --filter @open-codesign/ui test -- TooltiptypechecklintPrinciples §5b