fix(desktop): throw on unknown artifact type instead of silent html fallback

hqhq1025 · hqhq1025 · commit a7c2ce0c74bd · 2026-04-19T15:12:28.000+08:00
diff --git a/apps/desktop/src/renderer/src/store.toSnapshotArtifactType.test.ts b/apps/desktop/src/renderer/src/store.toSnapshotArtifactType.test.ts
@@ -0,0 +1,22 @@
+import { describe, expect, it } from 'vitest';
+import { toSnapshotArtifactType } from './store';
+
+describe('toSnapshotArtifactType', () => {
+  it('folds html/slides/bundle/undefined into html', () => {
+    expect(toSnapshotArtifactType(undefined)).toBe('html');
+    expect(toSnapshotArtifactType('html')).toBe('html');
+    expect(toSnapshotArtifactType('slides')).toBe('html');
+    expect(toSnapshotArtifactType('bundle')).toBe('html');
+  });
+
+  it('passes svg and react through', () => {
+    expect(toSnapshotArtifactType('svg')).toBe('svg');
+    expect(toSnapshotArtifactType('react')).toBe('react');
+  });
+
+  it('throws on unknown coreType instead of silently returning html', () => {
+    expect(() => toSnapshotArtifactType('mystery')).toThrow(
+      /Unsupported artifact type for snapshot persistence: mystery/,
+    );
+  });
+});
diff --git a/apps/desktop/src/renderer/src/store.ts b/apps/desktop/src/renderer/src/store.ts
@@ -283,13 +283,25 @@ function isDefaultDesignName(name: string): boolean {
 }
 
 // Core emits 'html' | 'svg' | 'slides' | 'bundle' but the snapshots schema only
-// stores 'html' | 'react' | 'svg' (see DesignSnapshotV1). 'slides'/'bundle' fall
-// through to 'html' because their on-disk source is HTML — keeping the column
+// stores 'html' | 'react' | 'svg' (see DesignSnapshotV1). 'slides'/'bundle' fold
+// into 'html' because their on-disk source is HTML — keeping the column
 // constraint stable means we don't need a schema migration to persist them.
-function toSnapshotArtifactType(coreType: string | undefined): 'html' | 'react' | 'svg' {
-  if (coreType === 'svg') return 'svg';
-  if (coreType === 'react') return 'react';
-  return 'html';
+// Unknown types throw so a new core ArtifactType doesn't silently round-trip
+// as the wrong renderer.
+export function toSnapshotArtifactType(coreType: string | undefined): 'html' | 'react' | 'svg' {
+  switch (coreType) {
+    case undefined:
+    case 'html':
+    case 'slides':
+    case 'bundle':
+      return 'html';
+    case 'svg':
+      return 'svg';
+    case 'react':
+      return 'react';
+    default:
+      throw new Error(`Unsupported artifact type for snapshot persistence: ${coreType}`);
+  }
 }
 
 interface PersistArtifact {
