Skip to content

[Enhancement] Manually Entered on Command Sender#2906

Merged
clayandgen merged 2 commits intomainfrom
enhancement/manually-entered
Mar 3, 2026
Merged

[Enhancement] Manually Entered on Command Sender#2906
clayandgen merged 2 commits intomainfrom
enhancement/manually-entered

Conversation

@clayandgen
Copy link
Copy Markdown
Contributor

@clayandgen clayandgen commented Mar 2, 2026

closes #2408

Let me know of any UI/UX suggestions

Screenshot 2026-03-02 at 3 31 31 PM

@clayandgen clayandgen requested review from jmthomas and ryanmelt March 2, 2026 22:33
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.25%. Comparing base (0ce3c12) to head (5bb8206).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2906      +/-   ##
==========================================
- Coverage   78.30%   78.25%   -0.06%     
==========================================
  Files         673      673              
  Lines       55142    55192      +50     
  Branches      728      728              
==========================================
+ Hits        43181    43192      +11     
- Misses      11883    11922      +39     
  Partials       78       78
Flag Coverage Δ
python 79.33% <ø> (-0.03%) ⬇️
ruby-api 79.73% <ø> (-0.45%) ⬇️
ruby-backend 82.17% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jmthomas
jmthomas approved these changes Mar 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@jmthomas jmthomas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried sending without entering a value and got Error sending INST COLLECT due to RuntimeError: invalid value for Integer(): "". I think that makes sense.

You have a Command Sender playwright test failing. Please look at that. Also add an explicit test for this in Playwright.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 3, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@clayandgen clayandgen merged commit 80b61ba into main Mar 3, 2026
48 of 50 checks passed
@clayandgen clayandgen deleted the enhancement/manually-entered branch March 3, 2026 21:53
jmthomas pushed a commit that referenced this pull request Mar 21, 2026
@clayandgen @jmthomas
[Enhancement] Manually Entered on Command Sender (#2906)
be7967b 
* [Enhancement] Manually Entered on Command Sender

* Add/fix playwright tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmthomas jmthomas jmthomas approved these changes

@ryanmelt ryanmelt Awaiting requested review from ryanmelt

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

"Manually Entered" on Command Sender

2 participants

@clayandgen @jmthomas