Skip to content

Fix migration and better handle migration errors#2901

Merged
jmthomas merged 5 commits intomainfrom
migration
Mar 3, 2026
Merged

Fix migration and better handle migration errors#2901
jmthomas merged 5 commits intomainfrom
migration

Conversation

@jmthomas
Copy link
Copy Markdown
Member

@jmthomas jmthomas commented Mar 1, 2026

We can't reinstall the plugins before fixing the various settings in the target model so I just combined them.

Also added a kwargs argument throughout the models to handle future migration issues like this. At least you'll be able to continue and carry on instead of the migration crashing. That said it will be harder to debug a migration issue in the future so maybe I'm talking myself out of it. Thoughts?

I decided to revert the kwargs change.

@jmthomas jmthomas requested review from clayandgen and ryanmelt March 1, 2026 01:35
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.29%. Comparing base (397abec) to head (c05e102).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2901   +/-   ##
=======================================
  Coverage   78.29%   78.29%           
=======================================
  Files         673      673           
  Lines       55130    55130           
  Branches      728      728           
=======================================
  Hits        43164    43164           
  Misses      11888    11888           
  Partials       78       78           
Flag Coverage Δ
python 79.34% <ø> (ø)
ruby-api 80.15% <ø> (ø)
ruby-backend 82.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 2, 2026

@jmthomas jmthomas merged commit d02ac06 into main Mar 3, 2026
30 of 32 checks passed
@jmthomas jmthomas deleted the migration branch March 3, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants