Skip to content

[Enhancement] Ability to hide Legend on TlmGrapher#2895

Merged
jmthomas merged 3 commits intomainfrom
enhancement/tlm-grapher-legend
Mar 5, 2026
Merged

[Enhancement] Ability to hide Legend on TlmGrapher#2895
jmthomas merged 3 commits intomainfrom
enhancement/tlm-grapher-legend

Conversation

@clayandgen
Copy link
Copy Markdown
Contributor

closes #1837

Using DOM manipulation to show / hide the legend, because uPlot requires this info on create, and with DOM manipulation we don't have to recreate the plot on legend setting change.

Screenshot 2026-02-27 at 11 17 22 AM Screenshot 2026-02-27 at 11 17 28 AM

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.28%. Comparing base (19e909e) to head (abd9a8a).
⚠️ Report is 60 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2895      +/-   ##
==========================================
- Coverage   78.29%   78.28%   -0.02%     
==========================================
  Files         673      673              
  Lines       55118    55205      +87     
  Branches      728      728              
==========================================
+ Hits        43157    43216      +59     
- Misses      11883    11911      +28     
  Partials       78       78              
Flag Coverage Δ
python 79.32% <ø> (-0.02%) ⬇️
ruby-api 80.11% <ø> (-0.14%) ⬇️
ruby-backend 82.16% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jmthomas
Copy link
Copy Markdown
Member

jmthomas commented Mar 3, 2026

Can we also put the hide option here:
image

This is where I would expect it. However once it disappears you can't bring it back that way. So maybe an info icon to say Restore via the Graph -> Settings dialog.

Copy link
Copy Markdown
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See Jason's comment about being able to hide from context menu.

@clayandgen
Copy link
Copy Markdown
Contributor Author

clayandgen commented Mar 4, 2026

Updated to include Hide Legend from the Context Menu -- which means that other components (like widgets in Tlm Viewer) also gain this as well.

Screenshot 2026-03-03 at 9 51 15 PM Screenshot 2026-03-03 at 9 57 50 PM Screenshot 2026-03-03 at 9 51 40 PM

@jmthomas
Copy link
Copy Markdown
Member

jmthomas commented Mar 4, 2026

I have to admit, I did not notice that little i in the right side of the grapher window. I think it's because we have so many icons over there already. Thoughts about putting it on the left side next to the edit icon? I think it would be more visible since there's only 1 icon on the left.

@clayandgen
Copy link
Copy Markdown
Contributor Author

Agreed, this looks better! Thanks for the suggestion, updated:

Screenshot 2026-03-04 at 9 57 31 AM

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 4, 2026

@jmthomas jmthomas requested review from jmthomas and ryanmelt March 4, 2026 22:09
@jmthomas jmthomas merged commit 255441d into main Mar 5, 2026
49 of 50 checks passed
@jmthomas jmthomas deleted the enhancement/tlm-grapher-legend branch March 5, 2026 00:27
jmthomas added a commit that referenced this pull request Mar 21, 2026
[Enhancement] Ability to hide Legend on TlmGrapher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Turn legend off in TlmGrapher

3 participants