Conversation
sprintf-js doesn't support BigInt values, causing format strings to be silently ignored for 64-bit integers. Add formatBigInt() to handle %d, %i, %u, %o, %x, %X specifiers with full precision. Also apply monospace font automatically for hex/octal format strings. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2892 +/- ##
==========================================
- Coverage 78.29% 78.29% -0.01%
==========================================
Files 673 673
Lines 55118 55118
Branches 728 728
==========================================
- Hits 43157 43156 -1
- Misses 11883 11884 +1
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
clayandgen
approved these changes
Feb 27, 2026
| // Apply monospace font for hex/octal format strings so digits align | ||
| const formatString = this.parameters[3] | ||
| if (formatString && /%-?#?\d*[xXo]/.test(formatString)) { | ||
| this.appliedSettings.push(['RAW', 'font-family', 'monospace']) |
jmthomas
added a commit
that referenced
this pull request
Mar 21, 2026
Fix FORMATVALUE widget for 64-bit integer values
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sprintf-js doesn't support BigInt values, causing format strings to be silently ignored for 64-bit integers. Add formatBigInt() to handle %d, %i, %u, %o, %x, %X specifiers with full precision. Also apply monospace font automatically for hex/octal format strings.