[Bughancement] Limit Bar on Zero and Colors on DetailsDialog#2891
[Bughancement] Limit Bar on Zero and Colors on DetailsDialog#2891clayandgen merged 2 commits intomainfrom
Conversation
| }, | ||
| calcPosition(value, limitsSettings) { | ||
| if (!value || !limitsSettings) { | ||
| if (value == null || !limitsSettings) { |
There was a problem hiding this comment.
This is what was causing the limit bar issue when value is 0
There was a problem hiding this comment.
I think there might be another on line 40.
| <v-row no-gutters> | ||
| <v-col cols="1"></v-col> | ||
| <v-col cols="4" class="label">With Units Value</v-col> | ||
| <v-col>{{ unitsValue }}</v-col> |
There was a problem hiding this comment.
@jmthomas -- we no longer have "With Units" right? Removing "With Units" from the Details Dialog.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2891 +/- ##
==========================================
- Coverage 78.83% 78.30% -0.53%
==========================================
Files 667 673 +6
Lines 54527 55118 +591
Branches 728 728
==========================================
+ Hits 42984 43162 +178
- Misses 11465 11878 +413
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
@jmthomas -- comments should be addressed. |
|
I think all the other examples are expecting an array which should be good. |
* [Bughancement] Limit Bar on Zero and Colors on DetailsDialog * Address PR Comments
2 participants
closes #2889
closes #2890
Error below when value is zero -- appears in the beginning of bar (even if bar extends beyond 0, like -10)
Fix below
Add color to the Details Dialog
