Fix Python Suite Runner to preserve add_script insertion order#2885
Merged
Fix Python Suite Runner to preserve add_script insertion order#2885
Conversation
The Python build_suites method was using set() + sort() to deduplicate scripts, which forced alphabetical ordering. Ruby's Array#uniq! preserves insertion order. Replaced with dict.fromkeys() to match Ruby behavior. Added tests for both Ruby and Python to verify script ordering. Co-Authored-By: Claude Opus 4.6 <[email protected]>
mcosgriff
approved these changes
Feb 26, 2026
mcosgriff
approved these changes
Feb 26, 2026
Contributor
mcosgriff
left a comment
mcosgriff
left a comment
There was a problem hiding this comment.
There are 4 sonarqube findings
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2885 +/- ##
==========================================
- Coverage 78.84% 78.30% -0.54%
==========================================
Files 667 673 +6
Lines 54527 55118 +591
Branches 728 728
==========================================
+ Hits 42990 43162 +172
- Misses 11459 11878 +419
Partials 78 78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
jmthomas
added a commit
that referenced
this pull request
Mar 21, 2026
Fix Python Suite Runner to preserve add_script insertion order
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python build_suites method was using set() + sort() to deduplicate scripts, which forced alphabetical ordering. Ruby's Array#uniq! preserves insertion order. Replaced with dict.fromkeys() to match Ruby behavior.
Added tests for both Ruby and Python to verify script ordering.