Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2871 +/- ##
==========================================
- Coverage 78.83% 78.82% -0.01%
==========================================
Files 667 667
Lines 54533 54543 +10
Branches 728 731 +3
==========================================
+ Hits 42990 42993 +3
- Misses 11465 11470 +5
- Partials 78 80 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| else | ||
| result.each do |tuples| | ||
| entry = { "__type" => "items" } | ||
| entry = { "__type" => "ITEMS" } |
There was a problem hiding this comment.
This was a regression that I caught porting the OpenMCT plugin
| # Required for Traefik v3.6.4+ which blocks them by default | ||
| allowEncodedSlash: true | ||
| ping: | ||
| entryPoint: "web" |
There was a problem hiding this comment.
Matching entry in Enterprise
| changeTools: | ||
| replacePathRegex: | ||
| regex: "^/([^/]*)/(.*)" | ||
| replacement: '/{{env "OPENC3_TOOLS_BUCKET"}}/$2' |
There was a problem hiding this comment.
You can use these types of go templates in traefik
| passHostHeader: false | ||
| servers: | ||
| - url: "http://openc3-buckets:9000" | ||
| - url: '{{ env "OPENC3_BUCKET_URL" }}' |
There was a problem hiding this comment.
This allows you to set the S3 url and seamlessly transition to real buckets
| unless validate_only | ||
| bucket = Bucket.getClient() | ||
| bucket.ensure_public(ENV['OPENC3_TOOLS_BUCKET']) | ||
| end |
There was a problem hiding this comment.
It's weird that the widget_model was applying the policy. This should be done in init now.
| && chmod -R 777 /openc3/ | ||
|
|
||
| ENV HOME=/openc3 | ||
| ENV XDG_CACHE_HOME=/tmp/.cache |
There was a problem hiding this comment.
Someone had an issue with a stack trace as follows:
23T18:11:59.332821Z","level":"ERROR","container_name":"2c0d7c5fb5a9","message":"Error undeploying plugin model openc3-cosmos-nowl-0.0.154.gem__0 in scope DEFAULT due to: EACCES : Permission denied @ dir_s_mkdir - /openc3/.cache/gem\n/usr/lib/ruby/3.4.0/fileutils.rb:403:in 'Dir.mkdir'\n/usr/lib/ruby/3.4.0/fileutils.rb:403:in 'FileUtils.fu_mkdir'\n/usr/lib/ruby/3.4.0/fileutils.rb:381:in 'block (2 levels) in FileUtils.mkdir_p'\n/usr/lib/ruby/3.4.0/fileutils.rb:379:in 'Array#reverse_each'\n/usr/lib/ruby/3.4.0/fileutils.rb:379:in 'block in FileUtils.mkdir_p'\n/usr/lib/ruby/3.4.0/fileutils.rb:371:in 'Array#each'\n/usr/lib/ruby/3.4.0/fileutils.rb:371:in 'FileUtils.mkdir_p'\n/usr/local/lib/site_ruby/3.4.0/rubygems/source.rb:136:in 'Gem::Source#fetch_spec'\n/usr/local/lib/site_ruby/3.4.0/rubygems/resolver/api_specification.rb:93:in 'Gem::Resolver::APISpecification#spec'\n/usr/local/lib/site_ruby/3.4.0/rubygems/resolver/activation_request.rb:91:in 'Gem::Resolver::ActivationRequest#full_spec'\n/usr/local/lib/site_ruby/3.4.0/rubygems/resolver/activation_request.rb:106:in 'Gem::Resolver::ActivationRequest#installed?'\n/usr/local/lib/site_ruby/3.4.0/rubygems/request_set.rb:174:in 'block (2 levels) in Gem::RequestSet#install'","type":"log"}
Permission denied in Dir.mkdir at /openc3/.cache/gem. Supposedly this sets the cache dir to /tmp which everyone has access to.
Note I was not able to reproduce this error.
There was a problem hiding this comment.
This will probably need to change when we move to readonly containers.
| # Change to arn:aws-us-gov for deploying to AWS Gov Cloud | ||
| OPENC3_AWS_ARN_PREFIX=arn:aws | ||
| # Update based on deployed region | ||
| AWS_REGION=us-east-1 |
There was a problem hiding this comment.
This is also required if using real S3
| MIGRATION_FILES_BEFORE_PAUSE=10 | ||
| # Seconds to pause after processing MIGRATION_FILES_BEFORE_PAUSE files | ||
| MIGRATION_PAUSE_SECONDS=30 | ||
|
|
There was a problem hiding this comment.
Dead code .. these are now part of the tsdb migration plugin
| client.ensure_public(ENV['OPENC3_TOOLS_BUCKET']) | ||
| end | ||
| # Always ensure the scriptrunner policy is in place since it is required for script execution | ||
| client.ensure_scriptrunner_policy(ENV['OPENC3_CONFIG_BUCKET'], ENV['OPENC3_LOGS_BUCKET']) |
There was a problem hiding this comment.
This wasn't happening in cloud deployments
| REQUESTS_CA_BUNDLE: "/devel/cacert.pem" | ||
| NODE_EXTRA_CA_CERTS: "/devel/cacert.pem" | ||
| env_file: | ||
| - .env |
There was a problem hiding this comment.
Only pass required environment variables not all of .env.
|
2 participants
No description provided.