Conversation
…nd CMD "python start.py"
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2851 +/- ##
==========================================
+ Coverage 77.68% 78.73% +1.05%
==========================================
Files 471 667 +196
Lines 34532 54496 +19964
Branches 731 731
==========================================
+ Hits 26827 42910 +16083
- Misses 7625 11506 +3881
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
ryanmelt
approved these changes
Feb 19, 2026
Member
ryanmelt
left a comment
ryanmelt
left a comment
There was a problem hiding this comment.
Looks good. There appears to be a real Playwright failure in TlmViewer that I'd like to fix in this PR. Please leave open and I'll merge once that is fixed.
mcosgriff
deleted the
when-replacing-python-binary-need-to-handle-quoted-and-unquoted
branch
jmthomas
pushed a commit
that referenced
this pull request
Mar 21, 2026
…ng and one word per parameter modes (#2851) * When replacing the python binary need to handle CMD python start.py and CMD "python start.py" * fix python unit test --------- Co-authored-by: Ryan Melton <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMD python start.pyandCMD "python start.py"need to replace just python in these cases.