Fix QuestDB ingress errors for Python conversions without converted_type#2849
Merged
Fix QuestDB ingress errors for Python conversions without converted_type#2849
Conversation
Three bugs fixed:
- __C columns from read_conversions with no converted_type (e.g. user Python
conversions) were created as VARCHAR but not tracked in json_columns, causing
INTEGER-to-VARCHAR cast errors on every row
- Table reconciliation on plugin reload issued unnecessary ALTER for DECIMAL
columns due to whitespace mismatch ("DECIMAL(20, 0)" vs "DECIMAL(20,0)")
- handle_ingress_error cast values for VARCHAR columns but didn't persist the
tracking, so the same error fired on every subsequent row
Replaced QUESTDB_TYPE_MAP dict with _canonical_type() that normalizes via
uppercase + whitespace stripping, preserving parameterized type identity.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2849 +/- ##
==========================================
+ Coverage 78.66% 78.69% +0.03%
==========================================
Files 667 667
Lines 54458 54465 +7
Branches 731 731
==========================================
+ Hits 42837 42859 +22
+ Misses 11541 11526 -15
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
ryanmelt
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three bugs fixed:
Replaced QUESTDB_TYPE_MAP dict with _canonical_type() that normalizes via uppercase + whitespace stripping, preserving parameterized type identity.