Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2838 +/- ##
==========================================
- Coverage 78.66% 78.64% -0.02%
==========================================
Files 667 667
Lines 54452 54466 +14
Branches 731 731
==========================================
+ Hits 42834 42836 +2
- Misses 11538 11550 +12
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ceptions The _status_thread now exits cleanly on error instead of raising an unhandled exception, which pytest detects as PytestUnhandledThreadExceptionWarning. TcpipClientStream.connect() now closes sockets on connection failure to prevent ResourceWarning from leaked file descriptors. Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
…mplete message The processLine handler for terminal states (completed, stopped, etc.) was calling scriptComplete() which unsubscribes the WebSocket channel before the 'complete' message carrying the suite report could arrive. Now only the 'complete' message handler triggers scriptComplete(). Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
ryanmelt
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update upgrade instructions. Fix python license. Only migrate logs and config buckets. Bump versitygw and valkey.
This turned into a bunch of other fixes that Playwright uncovered:
Fix File Open / Save dialog to disallow user interaction before targets are loaded
Fix Script Runner race condition that could allow the Suite report to be missed
Note: This also benefits Notebooks because it unsubscribes from the channel as soon as the type: "line" event with "completed" state arrives, potentially missing the last few output messages and the complete event
Fix python microservice to not raise unhandled exception in a status thread
Fix python TCP/IP Client to close sockets if there is an error in connect5.