Conversation
Textfields in floated telemetry viewer screens were unresponsive because the drag handler was calling preventDefault() on all mousedown events, blocking focus. Now only prevents default on non-interactive elements and restricts dragging to the toolbar. Also adds visual cursor hints (grab/pointer) and imports openc3-vue-common styles in tlmviewer.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2796 +/- ##
==========================================
- Coverage 78.72% 78.72% -0.01%
==========================================
Files 671 671
Lines 54809 54809
Branches 731 731
==========================================
- Hits 43148 43146 -2
- Misses 11581 11583 +2
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jmthomas
approved these changes
Feb 8, 2026
jmthomas
deleted the
2780-telemetry-viewer-textfield-widget-cannot-enter-text-when-floating
branch
jmthomas
added a commit
that referenced
this pull request
Mar 21, 2026
…widget-cannot-enter-text-when-floating Fix textfield input bug in float mode and improve drag UX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Textfields in floated telemetry viewer screens were unresponsive because the drag handler was calling preventDefault() on all mousedown events, blocking focus. Now only prevents default on non-interactive elements and restricts dragging to the toolbar. Also adds visual cursor hints (grab/pointer) and imports openc3-vue-common styles in tlmviewer
Screen.Recording.2026-02-06.at.2.20.46.PM.mov