Fix mnemonic checker crashes and false positives#2788
Merged
Conversation
- Fix undefined error when regex matches space-based syntax (use Group 2 instead of last group which can be undefined) - Strip trailing comments before checking for keywords to prevent matching keywords like 'wait' in comments - Extract only content within quoted strings for space-based command syntax to avoid including Ruby/Python keyword arguments (queue:, queue=) as command parameters Co-Authored-By: Claude Opus 4.5 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2788 +/- ##
==========================================
+ Coverage 78.71% 78.72% +0.01%
==========================================
Files 671 671
Lines 54809 54823 +14
Branches 731 731
==========================================
+ Hits 43143 43160 +17
+ Misses 11586 11583 -3
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ryan-pratt
approved these changes
Feb 5, 2026
|
jmthomas
added a commit
that referenced
this pull request
Mar 21, 2026
Fix mnemonic checker crashes and false positives
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2787