Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2770 +/- ##
==========================================
- Coverage 78.70% 78.70% -0.01%
==========================================
Files 671 671
Lines 54796 54795 -1
Branches 731 731
==========================================
- Hits 43128 43126 -2
- Misses 11588 11589 +1
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
| if (!this.screenValues[this.valueId]) { | ||
| return {} | ||
| } |
There was a problem hiding this comment.
When this widget first starts the screenValues might not be populated so this.screenValues[this.valueId][0] throws an error.
There was a problem hiding this comment.
Ok. I'd prefer to not have code changes in a dep update PR in the future - makes it easy to miss
| if image_name == 'traefik' | ||
| resp = client.get("https://registry.hub.docker.com/v2/repositories/library/traefik/tags?page_size=1024").body | ||
| elsif image_name == 'redis' | ||
| resp = client.get("https://registry.hub.docker.com/v2/repositories/valkey/valkey/tags?page_size=1024").body | ||
| end |
There was a problem hiding this comment.
Is this never called for anything besides traefik and redis?
There was a problem hiding this comment.
Yeah, it was written to be generic but we only call it in package_audit.rb with 'traefik' and 'redis'. It broke when we switched from redis to valkey.
2 participants
No description provided.