Add JsonAccessor buffer type tests and improve code quality#2754
Merged
Add JsonAccessor buffer type tests and improve code quality#2754
Conversation
…lity Add two test cases demonstrating JsonAccessor behavior with different buffer types: - Test that writing to empty bytearray raises JSONDecodeError (occurs with inject_tlm type="RAW" without TEMPLATE) - Test that writing to dict buffer works correctly (occurs with type="CONVERTED") Also improve code quality: - Replace wildcard imports with specific imports (remove unused unittest.mock and test.test_helper imports) - Use assertIsNone() instead of assertEqual(..., None) for better test readability - Fix minor formatting inconsistencies
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2754 +/- ##
=======================================
Coverage 79.16% 79.17%
=======================================
Files 670 670
Lines 54278 54278
Branches 734 734
=======================================
+ Hits 42971 42975 +4
+ Misses 11227 11223 -4
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
clayandgen
approved these changes
Jan 23, 2026
mcosgriff
deleted the
added-simple-unit-test-for-json-accessor-type-raw
branch
jmthomas
pushed a commit
that referenced
this pull request
Mar 21, 2026
…lity (#2754) Add two test cases demonstrating JsonAccessor behavior with different buffer types: - Test that writing to empty bytearray raises JSONDecodeError (occurs with inject_tlm type="RAW" without TEMPLATE) - Test that writing to dict buffer works correctly (occurs with type="CONVERTED") Also improve code quality: - Replace wildcard imports with specific imports (remove unused unittest.mock and test.test_helper imports) - Use assertIsNone() instead of assertEqual(..., None) for better test readability - Fix minor formatting inconsistencies
jmthomas
pushed a commit
that referenced
this pull request
Mar 21, 2026
…lity (#2754) Add two test cases demonstrating JsonAccessor behavior with different buffer types: - Test that writing to empty bytearray raises JSONDecodeError (occurs with inject_tlm type="RAW" without TEMPLATE) - Test that writing to dict buffer works correctly (occurs with type="CONVERTED") Also improve code quality: - Replace wildcard imports with specific imports (remove unused unittest.mock and test.test_helper imports) - Use assertIsNone() instead of assertEqual(..., None) for better test readability - Fix minor formatting inconsistencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two test cases demonstrating JsonAccessor behavior with different buffer types:
Also improve code quality:
Note: These unit tests came from talk with customer