Validate SCREEN params and fix options dialogs#2752
Conversation
- Fix CmdTlmServer refresh interval not being passed to tabs by making refreshInterval a prop in Updater.js mixin instead of data - Update refresh interval dialogs to use seconds instead of milliseconds - Add persistent dialogs with Save and Cancel buttons matching FileOpenSaveDialog styling - Add form validation requiring refresh interval to be at least 1 - Disable Save button when validation fails - Fix TlmGrapher SettingsDialog to properly implement v-model and emit save event instead of mutating props Co-Authored-By: Claude Opus 4.5 <[email protected]>
- Add validation for SCREEN width, height, and polling period parameters - Allow polling period of 0 to disable screen polling - Add validation for stale time and tooltip delay parameters - Use ConfigParserError for better error messages - Update screen.yaml documentation for polling period - Reorder CmdTlmServer routes to place DataFlowsTab before StatusTab - Add margin styling fixes for EditScreenDialog and AppNav Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
Screenshots of the changes: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2752 +/- ##
==========================================
- Coverage 79.18% 79.17% -0.01%
==========================================
Files 670 670
Lines 54278 54259 -19
Branches 734 731 -3
==========================================
- Hits 42978 42958 -20
- Misses 11220 11221 +1
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
clayandgen
left a comment
clayandgen
left a comment
There was a problem hiding this comment.
SonarQube issues seem simple to implement -- worth addressing I think!
clayandgen
left a comment
clayandgen
left a comment
There was a problem hiding this comment.
Looks like you can set the Refresh Interval on Tlm Grapher to 1ms -- but I don't see changes to the API calls. How does that refresh interval work?
The Screen polling rate change looks good
The refresh is passed to |
|
Validate SCREEN params and fix options dialogs
3 participants
Once I started going through the various options dialog I realized the CmdTlmServer one was completely broken. I implemented the same look and feel throughout including Cancel Save buttons and Esc to close the dialog without changes.
closes #2739