Skip to content

Add hint to admin console about setting k8s secrets#2750

Merged
ryan-pratt merged 2 commits intomainfrom
feat/k8s-secrets-alert
Jan 21, 2026
Merged

Add hint to admin console about setting k8s secrets#2750
ryan-pratt merged 2 commits intomainfrom
feat/k8s-secrets-alert

Conversation

@ryan-pratt
Copy link
Copy Markdown
Contributor

@ryan-pratt ryan-pratt commented Jan 21, 2026

image

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 21, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.16%. Comparing base (54f02a2) to head (0253f43).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2750      +/-   ##
==========================================
+ Coverage   78.23%   79.16%   +0.92%     
==========================================
  Files         473      670     +197     
  Lines       34520    54275   +19755     
  Branches      734      734              
==========================================
+ Hits        27008    42968   +15960     
- Misses       7432    11227    +3795     
  Partials       80       80
Flag Coverage Δ
python 80.95% <ø> (-15.09%) ⬇️
ruby-api 83.61% <ø> (-0.05%) ⬇️
ruby-backend 82.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

clayandgen
clayandgen reviewed Jan 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@clayandgen clayandgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubectl is not the only way to set Kube secrets, notably for most on k8s are probably using helm charts. Maybe change the wording to "You must set them in Kubernetes as a Secrets object", with a hyperlink to : https://kubernetes.io/docs/concepts/configuration/secret/ ?

@ryan-pratt ryan-pratt requested a review from clayandgen January 21, 2026 21:04
@ryan-pratt ryan-pratt force-pushed the feat/k8s-secrets-alert branch from 45ddafa to 0253f43 Compare January 21, 2026 21:07
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 21, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ryan-pratt ryan-pratt merged commit 07fdd39 into main Jan 21, 2026
47 of 48 checks passed
@ryan-pratt ryan-pratt deleted the feat/k8s-secrets-alert branch January 21, 2026 22:07
jmthomas pushed a commit that referenced this pull request Mar 21, 2026
@ryan-pratt @jmthomas
Merge pull request #2750 from OpenC3/feat/k8s-secrets-alert
2aacf1d 
Add hint to admin console about setting k8s secrets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmthomas jmthomas jmthomas approved these changes

@clayandgen clayandgen clayandgen approved these changes

@ryanmelt ryanmelt Awaiting requested review from ryanmelt

@EmilyRagan EmilyRagan Awaiting requested review from EmilyRagan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ryan-pratt @jmthomas @clayandgen